🐛 Fix comment loading crash

This commit is contained in:
Belén Albeza 2025-04-23 11:43:30 +02:00
parent 40fe6369cb
commit 1a7d60bb88
3 changed files with 51 additions and 0 deletions

View file

@ -0,0 +1,26 @@
[
{
"~:features": {
"~#set": [
"render-wasm",
"layout/grid",
"styles/v2",
"fdata/pointer-map",
"fdata/objects-map",
"components/v2",
"fdata/shape-data-type"
]
},
"~:permissions": {
"~:type": "~:membership",
"~:is-owner": true,
"~:is-admin": true,
"~:can-edit": true
},
"~:name": "Default",
"~:modified-at": "~m1713533116375",
"~:id": "~uc7ce0794-0992-8105-8004-38e630f7920a",
"~:created-at": "~m1713533116375",
"~:is-default": true
}
]

View file

@ -0,0 +1,23 @@
import { test, expect } from "@playwright/test";
import { WorkspacePage } from "../pages/WorkspacePage";
import { BaseWebSocketPage } from "../pages/BaseWebSocketPage";
test.beforeEach(async ({ page }) => {
await WorkspacePage.init(page);
await BaseWebSocketPage.mockRPC(
page,
"get-teams",
"get-teams-render-wasm.json",
);
});
test("BUG 10867 - Crash when loading comments", async ({ page }) => {
const workspacePage = new WorkspacePage(page);
await workspacePage.setupEmptyFile();
await workspacePage.goToWorkspace();
await workspacePage.showComments();
await expect(
workspacePage.rightSidebar.getByText("Show all comments"),
).toBeVisible();
});

View file

@ -105,6 +105,7 @@
workspace-editor-state (mf/deref refs/workspace-editor-state)
workspace-v2-editor-state (mf/deref refs/workspace-v2-editor-state)
file-id (get file :id)
objects (get page :objects)
page-id (get page :id)
background (get page :background clr/canvas)
@ -341,6 +342,7 @@
(when show-comments?
[:> comments/comments-layer* {:vbox vbox
:page-id page-id
:file-id file-id
:vport vport
:zoom zoom}])