From 14b53a4d5e73732309b59a4390c54e0d40a87ede Mon Sep 17 00:00:00 2001
From: Andrey Antukh <niwi@niwi.nz>
Date: Mon, 20 Feb 2023 12:16:23 +0100
Subject: [PATCH] :sparkles: Don't log duplicate traceback

---
 backend/resources/log4j2-devenv.xml   |  4 ++--
 common/src/app/common/exceptions.cljc |  1 +
 common/src/app/common/logging.cljc    | 12 ++++++------
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/backend/resources/log4j2-devenv.xml b/backend/resources/log4j2-devenv.xml
index 4625a47bf6..8c11428871 100644
--- a/backend/resources/log4j2-devenv.xml
+++ b/backend/resources/log4j2-devenv.xml
@@ -3,12 +3,12 @@
   <Appenders>
     <Console name="console" target="SYSTEM_OUT">
       <PatternLayout pattern="[%d{YYYY-MM-dd HH:mm:ss.SSS}] %level{length=1} %logger{36} - %msg%n"
-                     alwaysWriteExceptions="false" />
+                     alwaysWriteExceptions="true" />
     </Console>
 
     <RollingFile name="main" fileName="logs/main.log" filePattern="logs/main-%i.log">
       <PatternLayout pattern="[%d{YYYY-MM-dd HH:mm:ss.SSS}] %level{length=1} %logger{36} - %msg%n"
-                     alwaysWriteExceptions="false" />
+                     alwaysWriteExceptions="true" />
       <Policies>
         <SizeBasedTriggeringPolicy size="50M"/>
       </Policies>
diff --git a/common/src/app/common/exceptions.cljc b/common/src/app/common/exceptions.cljc
index 40d69f9fee..8a3d90ae29 100644
--- a/common/src/app/common/exceptions.cljc
+++ b/common/src/app/common/exceptions.cljc
@@ -178,6 +178,7 @@
                     (print-detail cause)
                     (recur cause))))))
           ]
+
     (with-out-str
       (print-all cause)))))
 
diff --git a/common/src/app/common/logging.cljc b/common/src/app/common/logging.cljc
index efd473d546..dd5706455f 100644
--- a/common/src/app/common/logging.cljc
+++ b/common/src/app/common/logging.cljc
@@ -243,12 +243,12 @@
                        (some? trace)
                        (str "\n" @trace))]
          (case level
-           :trace (.trace ^Logger logger ^String message ^Throwable cause)
-           :debug (.debug ^Logger logger ^String message ^Throwable cause)
-           :info  (.info  ^Logger logger ^String message ^Throwable cause)
-           :warn  (.warn  ^Logger logger ^String message ^Throwable cause)
-           :error (.error ^Logger logger ^String message ^Throwable cause)
-           :fatal (.error ^Logger logger ^String message ^Throwable cause)
+           :trace (.trace ^Logger logger ^String message)
+           :debug (.debug ^Logger logger ^String message)
+           :info  (.info  ^Logger logger ^String message)
+           :warn  (.warn  ^Logger logger ^String message)
+           :error (.error ^Logger logger ^String message)
+           :fatal (.error ^Logger logger ^String message)
            (throw (IllegalArgumentException. (str "invalid level:"  level))))))))
 
 #?(:cljs