3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-07-26 00:37:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

✨ On swap components do not render miniatures for components outside the screen

Browse source
This commit is contained in:
Pablo Alba 2023-10-24 13:52:44 +02:00 • committed by Andrés Moya
parent 587735a901
commit 02399add7a
1 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

53
frontend/src/app/main/ui/workspace/sidebar/options/menus/component.cljs
View file

@ -21,6 +21,7 @@
[app.main.ui.components.dropdown :refer [dropdown]] [app.main.ui.components.dropdown :refer [dropdown]]
[app.main.ui.components.title-bar :refer [title-bar]] [app.main.ui.components.title-bar :refer [title-bar]]
[app.main.ui.context :as ctx] [app.main.ui.context :as ctx]
[app.main.ui.hooks :as h]
[app.main.ui.icons :as i] [app.main.ui.icons :as i]
[app.main.ui.workspace.sidebar.assets.common :as cmm] [app.main.ui.workspace.sidebar.assets.common :as cmm]
[app.util.dom :as dom] [app.util.dom :as dom]
@ -144,6 +145,31 @@
(when (or @editing? creating?) (when (or @editing? creating?)
[:div.counter (str @size "/300")])]]))) [:div.counter (str @size "/300")])]])))
(mf/defc component-swap-item
{::mf/wrap-props false}
[{:keys [item loop? shapes file-id root-shape container component-id] :as props}]
(let [on-select-component
(mf/use-fn
#(when-not loop?
(st/emit! (dwl/component-multi-swap shapes file-id (:id item)))))
item-ref (mf/use-ref)
visible? (h/use-visible item-ref :once? true)]
[:div.component-item
{:ref item-ref
:class (stl/css-case :disabled loop?)
:key (:id item)
:on-click on-select-component}
(when visible?
[:& cmm/component-item-thumbnail {:file-id (:file-id item)
:root-shape root-shape
:component item
:container container}])
[:span.component-name
{:class (stl/css-case :selected (= (:id item) component-id))}
(:name item)]]))
(mf/defc component-swap (mf/defc component-swap
[{:keys [shapes] :as props}] [{:keys [shapes] :as props}]
(let [single? (= 1 (count shapes)) (let [single? (= 1 (count shapes))
@ -313,22 +339,17 @@
root-shape (ctf/get-component-root data item) root-shape (ctf/get-component-root data item)
loop? (or (contains? parent-components (:main-instance-id item)) loop? (or (contains? parent-components (:main-instance-id item))
(contains? parent-components (:id item)))] (contains? parent-components (:id item)))]
[:div.component-item [:& component-swap-item {:item item
{:class (stl/css-case :disabled loop?) :loop? loop?
:key (:id item) :shapes shapes
:on-click #(when-not loop? :file-id (:file-id filters)
(st/emit! :root-shape root-shape
(dwl/component-multi-swap shapes (:file-id filters) (:id item))))} :container container
[:& cmm/component-item-thumbnail {:file-id (:file-id item) :component-id current-comp-id}])
:root-shape root-shape (let [on-group-click #(on-enter-group item)]
:component item [:div.component-group {:key (uuid/next) :on-click on-group-click}
:container container}] [:span (cph/last-path item)]
[:span.component-name [:span i/arrow-slide]])))]]]))
{:class (stl/css-case :selected (= (:id item) current-comp-id))}
(:name item)]])
[:div.component-group {:key (uuid/next) :on-click #(on-enter-group item)}
[:span (cph/last-path item)]
[:span i/arrow-slide]]))]]]))
(mf/defc component-ctx-menu (mf/defc component-ctx-menu
[{:keys [menu-entries on-close show type] :as props}] [{:keys [menu-entries on-close show type] :as props}]