refactor: unify error handling behavior (#6755)

* refactor: unify error handling behavior

* revert

* normalize paths

* test...

* change

* does this work...

* fix...

* maybe fix

* maybe fix

* fix

* fix...
This commit is contained in:
Joshua Chen 2022-02-25 15:07:13 +08:00 committed by GitHub
parent dcbf9f644e
commit f903422617
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
58 changed files with 1123 additions and 299 deletions

View file

@ -26,8 +26,8 @@ function getBrowserStorage(
}
try {
return window[storageType];
} catch (e) {
logOnceBrowserStorageNotAvailableWarning(e as Error);
} catch (err) {
logOnceBrowserStorageNotAvailableWarning(err as Error);
return null;
}
}
@ -98,23 +98,26 @@ export const createStorageSlot = (
get: () => {
try {
return browserStorage.getItem(key);
} catch (e) {
console.error(`Docusaurus storage error, can't get key=${key}`, e);
} catch (err) {
console.error(`Docusaurus storage error, can't get key=${key}`, err);
return null;
}
},
set: (value) => {
try {
browserStorage.setItem(key, value);
} catch (e) {
console.error(`Docusaurus storage error, can't set ${key}=${value}`, e);
} catch (err) {
console.error(
`Docusaurus storage error, can't set ${key}=${value}`,
err,
);
}
},
del: () => {
try {
browserStorage.removeItem(key);
} catch (e) {
console.error(`Docusaurus storage error, can't delete key=${key}`, e);
} catch (err) {
console.error(`Docusaurus storage error, can't delete key=${key}`, err);
}
},
};

View file

@ -75,7 +75,7 @@ function useLocalePluralForms(): LocalePluralForms {
if (Intl.PluralRules) {
try {
return createLocalePluralForms(currentLocale);
} catch (e) {
} catch {
console.error(`Failed to use Intl.PluralRules for locale "${currentLocale}".
Docusaurus will fallback to a default/fallback (English) Intl.PluralRules implementation.
`);