From f8a6b391cd609ab1bd94e3f9e2a28e417b848704 Mon Sep 17 00:00:00 2001 From: Anh Hong Date: Thu, 5 Nov 2020 18:33:08 +0700 Subject: [PATCH] refactor(v2): improve regex matching code-block title (#3685) --- .../docusaurus-theme-classic/src/theme/CodeBlock/index.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx b/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx index 5a61badac7..10eac4fd93 100644 --- a/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx @@ -84,7 +84,7 @@ const highlightDirectiveRegex = (lang) => { return getHighlightDirectiveRegex(); } }; -const codeBlockTitleRegex = /title=".*"/; +const codeBlockTitleRegex = /(?:title=")(.*)(?:")/; export default ({ children, @@ -125,9 +125,7 @@ export default ({ // Tested above // eslint-disable-next-line @typescript-eslint/no-non-null-assertion codeBlockTitle = metastring - .match(codeBlockTitleRegex)![0] - .split('title=')[1] - .replace(/"+/g, ''); + .match(codeBlockTitleRegex)![1]; } let language =