diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 35f6fc6d67..bcaead6565 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -87,10 +87,11 @@ Small pull requests are much easier to review and more likely to get merged. Mak Please make sure the following is done when submitting a pull request: 1. Fork [the repository](https://github.com/facebook/docusaurus) and create your branch from `master`. -2. Add the copyright notice to the top of any code new files you've added. -3. Describe your [**test plan**](#test-plan) in your pull request description. Make sure to [test your changes](https://github.com/facebook/Docusaurus/blob/master/admin/testing-changes-on-Docusaurus-itself.md)! -4. Make sure your code lints (`npm run prettier`). -5. If you haven't already, [sign the CLA](https://code.facebook.com/cla). +1. Add the copyright notice to the top of any code new files you've added. +1. Describe your [**test plan**](#test-plan) in your pull request description. Make sure to [test your changes](https://github.com/facebook/Docusaurus/blob/master/admin/testing-changes-on-Docusaurus-itself.md)! +1. Make sure your code lints (`npm run prettier`). +1. Make sure our Jest tests pass (`npm run test`). +1. If you haven't already, [sign the CLA](https://code.facebook.com/cla). All pull requests should be opened against the `master` branch.