ESLintify Part 1 (#837)

* ESLint-ify

* Allow empty try/catch

* Escape regexp
This commit is contained in:
Yangshun Tay 2018-07-08 09:13:18 -07:00 committed by GitHub
parent 128dbfca0a
commit e8e3f42685
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
44 changed files with 466 additions and 555 deletions

View file

@ -66,7 +66,8 @@ function readSidebar() {
for (let i = 0; i < ids.length; i++) {
const id = ids[i];
let previous, next;
let previous;
let next;
if (i > 0) previous = ids[i - 1];
if (i < ids.length - 1) next = ids[i + 1];
order[id] = {
@ -86,13 +87,13 @@ function processMetadata(file, refDir) {
const language = utils.getLanguage(file, refDir) || 'en';
const metadata = {};
for (const fieldName of Object.keys(result.metadata)) {
Object.keys(result.metadata).forEach(fieldName => {
if (SupportedHeaderFields.has(fieldName)) {
metadata[fieldName] = result.metadata[fieldName];
} else {
console.warn(`Header field "${fieldName}" in ${file} is not supported.`);
}
}
});
const rawContent = result.rawContent;
@ -193,10 +194,8 @@ function generateMetadataDocs() {
// create a default list of documents for each enabled language based on docs in English
// these will get replaced if/when the localized file is downloaded from crowdin
enabledLanguages
.filter(currentLanguage => {
return currentLanguage != 'en';
})
.map(currentLanguage => {
.filter(currentLanguage => currentLanguage !== 'en')
.forEach(currentLanguage => {
let baseMetadata = Object.assign({}, metadata);
baseMetadata['id'] = baseMetadata['id']
.toString()
@ -291,7 +290,7 @@ function generateMetadataDocs() {
});
fs.writeFileSync(
__dirname + '/../core/metadata.js',
path.join(__dirname, '/../core/metadata.js'),
'/**\n' +
' * @' +
'generated\n' + // separate this out for Nuclide treating @generated as readonly
@ -360,7 +359,7 @@ function generateMetadataBlog() {
);
fs.writeFileSync(
__dirname + '/../core/MetadataBlog.js',
path.join(__dirname, '/../core/MetadataBlog.js'),
'/**\n' +
' * @' +
'generated\n' + // separate this out for Nuclide treating @generated as readonly