Prefer non-null assertions

Signed-off-by: Josh-Cena <sidachen2003@gmail.com>

.eslintrc.js

@@ -92,6 +92,7 @@ module.exports = {
     'no-unused-vars': OFF,
     'no-nested-ternary': WARNING,
     '@typescript-eslint/no-empty-function': OFF,
+    '@typescript-eslint/no-non-null-assertion': OFF, // Have to use type assertion anyways
     '@typescript-eslint/no-unused-vars': [ERROR, {argsIgnorePattern: '^_'}],
     '@typescript-eslint/ban-ts-comment': [
       ERROR,

packages/docusaurus-plugin-content-blog/src/blogUtils.ts

@@ -32,7 +32,7 @@ import {LoadContext} from '@docusaurus/types';
 import {validateBlogPostFrontMatter} from './blogFrontMatter';
 
 export function truncate(fileString: string, truncateMarker: RegExp): string {
-  return fileString.split(truncateMarker, 1).shift() as string;
+  return fileString.split(truncateMarker, 1).shift()!;
 }
 
 export function getSourceToPermalink(

packages/docusaurus-plugin-content-docs/src/client/docsClientUtils.ts

@@ -75,7 +75,7 @@ export type ActiveDocContext = {
 };
 
 export const getLatestVersion = (data: GlobalPluginData): Version => {
-  return data.versions.find((version) => version.isLast) as GlobalVersion;
+  return data.versions.find((version) => version.isLast)!;
 };
 
 // Note: return undefined on doc-unrelated pages,

packages/docusaurus-plugin-content-docs/src/index.ts

@@ -253,9 +253,7 @@ export default function pluginContentDocs(
           if (versionHomeDoc) {
             return versionHomeDoc;
           } else if (firstDocIdOfFirstSidebar) {
-            return docs.find(
+            return docs.find((doc) => doc.id === firstDocIdOfFirstSidebar)!;
-              (doc) => doc.id === firstDocIdOfFirstSidebar,
-            ) as DocMetadata;
           } else {
             return docs[0];
           }

packages/docusaurus-plugin-content-docs/src/sidebarItemsGenerator.ts

@@ -97,7 +97,7 @@ function parseBreadcrumb(
 ): {parents: string[]; tail: string} {
   return {
     parents: take(breadcrumb, breadcrumb.length - 1),
-    tail: last(breadcrumb) as string,
+    tail: last(breadcrumb)!,
   };
 }
 

packages/docusaurus-theme-classic/src/translations.ts

@@ -35,7 +35,7 @@ function getNavbarTranslationFile(navbar: Navbar): TranslationFileContent {
   )
     .keyBy((navbarItem) => `item.label.${navbarItem.label}`)
     .mapValues((navbarItem) => ({
-      message: navbarItem.label as string,
+      message: navbarItem.label!,
       description: `Navbar item with label ${navbarItem.label}`,
     }))
     .value();
@@ -78,7 +78,7 @@ function getFooterTranslationFile(footer: Footer): TranslationFileContent {
   )
     .keyBy((link) => `link.title.${link.title}`)
     .mapValues((link) => ({
-      message: link.title as string,
+      message: link.title!,
       description: `The title of the footer links column with title=${link.title} in the footer`,
     }))
     .value();
@@ -90,7 +90,7 @@ function getFooterTranslationFile(footer: Footer): TranslationFileContent {
   )
     .keyBy((linkItem) => `link.item.label.${linkItem.label}`)
     .mapValues((linkItem) => ({
-      message: linkItem.label as string,
+      message: linkItem.label!,
       description: `The label of footer link with label=${
         linkItem.label
       } linking to ${linkItem.to ?? linkItem.href}`,

packages/docusaurus/src/server/index.ts

@@ -309,7 +309,7 @@ ${Object.keys(registry)
   const siteMetadata: DocusaurusSiteMetadata = {
     docusaurusVersion: getPackageJsonVersion(
       join(__dirname, '../../package.json'),
-    ) as string,
+    )!,
     siteVersion: getPackageJsonVersion(join(siteDir, 'package.json')),
     pluginVersions: {},
   };