3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-20 20:46:58 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): fix error with required href attr of link in mobiles (#3607)

Browse source
This commit is contained in:
Alexey Pyltsyn 2020-10-19 18:17:57 +03:00 • committed by GitHub
parent 6cfadb89eb
commit e5448d9a96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/docusaurus-theme-classic/src/theme/NavbarItem/DefaultNavbarItem.tsx
View file

@ -184,6 +184,7 @@ function NavItemMobile({
'menu__list-item--collapsed': collapsed, 'menu__list-item--collapsed': collapsed,
})}> })}>
<NavLink <NavLink
role="button"
className={navLinkClassNames(className, true)} className={navLinkClassNames(className, true)}
{...props} {...props}
onClick={() => { onClick={() => {

3
packages/docusaurus/src/client/exports/Link.tsx
View file

@ -146,7 +146,8 @@ function Link({
// eslint-disable-next-line jsx-a11y/anchor-has-content // eslint-disable-next-line jsx-a11y/anchor-has-content
<a <a
href={targetLink} href={targetLink}
{...(!isInternal && {target: '_blank', rel: 'noopener noreferrer'})} {...(targetLinkUnprefixed &&
!isInternal && {target: '_blank', rel: 'noopener noreferrer'})}
{...props} {...props}
/> />
) : ( ) : (