3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-03 20:27:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: avoid flash of page scrolling to top on refresh (#7342)

Browse source
This commit is contained in:
Sébastien Lorber 2022-05-05 13:39:10 +02:00 • committed by GitHub
parent 0cc4fa82c1
commit dfe743c660
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/docusaurus/src/client/ClientLifecyclesDispatcher.tsx
View file

@ -27,6 +27,17 @@ export function dispatchLifecycleAction<K extends keyof ClientModule>(
return () => callbacks.forEach((cb) => cb?.()); return () => callbacks.forEach((cb) => cb?.());
} }
function scrollAfterNavigation(location: Location) {
const {hash} = location;
if (!hash) {
window.scrollTo(0, 0);
} else {
const id = decodeURIComponent(hash.substring(1));
const element = document.getElementById(id);
element?.scrollIntoView();
}
}
function ClientLifecyclesDispatcher({ function ClientLifecyclesDispatcher({
children, children,
location, location,
@ -38,13 +49,8 @@ function ClientLifecyclesDispatcher({
}): JSX.Element { }): JSX.Element {
useLayoutEffect(() => { useLayoutEffect(() => {
if (previousLocation !== location) { if (previousLocation !== location) {
const {hash} = location; if (previousLocation) {
if (!hash) { scrollAfterNavigation(location);
window.scrollTo(0, 0);
} else {
const id = decodeURIComponent(hash.substring(1));
const element = document.getElementById(id);
element?.scrollIntoView();
} }
dispatchLifecycleAction('onRouteDidUpdate', {previousLocation, location}); dispatchLifecycleAction('onRouteDidUpdate', {previousLocation, location});
} }