3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-08-06 10:20:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: replace apostrophe with empty string in header slugification (#1618)

Browse source 
* Replace apostrophe with empty string in header

This change is to replicate the github behviour with respect to apostrophe in
headers. When there is an apostrophe in a header, github replaces it with empty string
when creating an anchor link to that header. Docusaurus should follow the same convention.
This commit is contained in:
Parth Patel 2019-06-21 20:40:04 -04:00 • committed by Yangshun Tay
parent 9e84525bcf
commit db44eccac3
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/docusaurus-1.x/lib/core/__tests__/toSlug.test.js
View file

@ -16,6 +16,8 @@ const toSlug = require('../toSlug');
['Someting long ...', 'someting-long-'], ['Someting long ...', 'someting-long-'],
['foo_bar', 'foo_bar'], ['foo_bar', 'foo_bar'],
['some _ heading', 'some-_-heading'], ['some _ heading', 'some-_-heading'],
["I'm good", 'im-good'],
['This is awes’ome', 'this-is-awesome'],
].forEach(([input, output]) => { ].forEach(([input, output]) => {
test(`toSlug('${input}') -> '${output}'`, () => { test(`toSlug('${input}') -> '${output}'`, () => {
expect(toSlug(input)).toBe(output); expect(toSlug(input)).toBe(output);

4
packages/docusaurus-1.x/lib/core/toSlug.js
View file

@ -45,8 +45,8 @@ module.exports = (string, context = {}) => {
.replace(new RegExp(`[${accents}]`, 'g'), c => .replace(new RegExp(`[${accents}]`, 'g'), c =>
without.charAt(accents.indexOf(c)), without.charAt(accents.indexOf(c)),
) )
// Replace `.`, `(` and `?` with blank string like Github does // Replace `'`, `’`, `.`, `(` and `?` with blank string like GitHub does
.replace(/\.|\(|\?/g, '') .replace(/'|’|\.|\(|\?/g, '')
// Dash special characters except '_' (underscore) // Dash special characters except '_' (underscore)
.replace(exceptAlphanumAndUnderscore, '-') .replace(exceptAlphanumAndUnderscore, '-')
// Compress multiple dash // Compress multiple dash