3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-06-07 21:32:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): remove event listeners on Tabs component unmount (#3599)

Browse source
This commit is contained in:
Alexey Pyltsyn 2020-10-16 19:15:48 +03:00 • committed by GitHub
parent 8f5c632cdf
commit da6268911c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/docusaurus-theme-bootstrap/src/theme/Tabs/index.tsx
View file

@ -106,6 +106,11 @@ function Tabs(props: Props): JSX.Element {
useEffect(() => { useEffect(() => {
window.addEventListener('keydown', handleKeyboardEvent); window.addEventListener('keydown', handleKeyboardEvent);
window.addEventListener('mousedown', handleMouseEvent); window.addEventListener('mousedown', handleMouseEvent);
return () => {
window.removeEventListener('keydown', handleKeyboardEvent);
window.removeEventListener('mousedown', handleMouseEvent);
};
}, []); }, []);
return ( return (

5
packages/docusaurus-theme-classic/src/theme/Tabs/index.tsx
View file

@ -93,6 +93,11 @@ function Tabs(props: Props): JSX.Element {
useEffect(() => { useEffect(() => {
window.addEventListener('keydown', handleKeyboardEvent); window.addEventListener('keydown', handleKeyboardEvent);
window.addEventListener('mousedown', handleMouseEvent); window.addEventListener('mousedown', handleMouseEvent);
return () => {
window.removeEventListener('keydown', handleKeyboardEvent);
window.removeEventListener('mousedown', handleMouseEvent);
};
}, []); }, []);
return ( return (