3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-07-25 04:28:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): navbar, allow unknown attributes (#3140)

Browse source
This commit is contained in:
Sébastien Lorber 2020-07-28 12:52:01 +02:00 • committed by GitHub
parent 33bb9087cf
commit d1a27efe8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/docusaurus-theme-classic/src/themeConfigSchema.js
View file

@ -22,7 +22,10 @@ const DefaultNavbarItemSchema = Joi.object({
activeBaseRegex: Joi.string(), activeBaseRegex: Joi.string(),
className: Joi.string(), className: Joi.string(),
'aria-label': Joi.string(), 'aria-label': Joi.string(),
}); })
// We allow any unknown attributes on the links
// (users may need additional attributes like target, aria-role, data-customAttribute...)
.unknown();
// TODO the dropdown parent item can have no href/to // TODO the dropdown parent item can have no href/to
// should check should not apply to dropdown parent item // should check should not apply to dropdown parent item
// .xor('href', 'to'); // .xor('href', 'to');