refactor: enforce type import specifiers (#6230)

* refactor: enforce type import specifiers

* fix

* Upgrade esbuild

* Fix (haha)

packages/docusaurus-plugin-content-docs/src/sidebars/__tests__/generator.test.ts

@@ -5,8 +5,11 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {CategoryMetadataFile, DefaultSidebarItemsGenerator} from '../generator';
-import {Sidebar, SidebarItemsGenerator} from '../types';
+import {
+  DefaultSidebarItemsGenerator,
+  type CategoryMetadataFile,
+} from '../generator';
+import type {Sidebar, SidebarItemsGenerator} from '../types';
 import fs from 'fs-extra';
 import {DefaultNumberPrefixParser} from '../../numberPrefix';
 

packages/docusaurus-plugin-content-docs/src/sidebars/__tests__/processor.test.ts

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {processSidebars, SidebarProcessorParams} from '../processor';
+import {processSidebars, type SidebarProcessorParams} from '../processor';
 import type {
   SidebarItem,
   SidebarItemsGenerator,
@@ -14,7 +14,7 @@ import type {
 } from '../types';
 import {DefaultSidebarItemsGenerator} from '../generator';
 import {createSlugger} from '@docusaurus/utils';
-import {VersionMetadata} from '../../types';
+import type {VersionMetadata} from '../../types';
 import {DefaultNumberPrefixParser} from '../../numberPrefix';
 
 describe('processSidebars', () => {

packages/docusaurus-plugin-content-docs/src/sidebars/__tests__/utils.test.ts

@@ -12,12 +12,12 @@ import {
   collectSidebarLinks,
   transformSidebarItems,
   collectSidebarsDocIds,
-  SidebarNavigation,
+  type SidebarNavigation,
   toDocNavigationLink,
   toNavigationLink,
 } from '../utils';
 import type {Sidebar, Sidebars} from '../types';
-import {DocMetadataBase, DocNavLink} from '../../types';
+import type {DocMetadataBase, DocNavLink} from '../../types';
 
 describe('createSidebarsUtils', () => {
   const sidebar1: Sidebar = [

packages/docusaurus-plugin-content-docs/src/sidebars/__tests__/validation.test.ts

@@ -6,8 +6,8 @@
  */
 
 import {validateSidebars, validateCategoryMetadataFile} from '../validation';
-import {CategoryMetadataFile} from '../generator';
-import {SidebarsConfig} from '../types';
+import type {CategoryMetadataFile} from '../generator';
+import type {SidebarsConfig} from '../types';
 
 describe('validateSidebars', () => {
   // TODO add more tests

packages/docusaurus-plugin-content-docs/src/sidebars/index.ts

@@ -11,7 +11,7 @@ import type {SidebarsConfig, Sidebars, NormalizedSidebars} from './types';
 import type {NormalizeSidebarsParams, PluginOptions} from '../types';
 import {validateSidebars} from './validation';
 import {normalizeSidebars} from './normalization';
-import {processSidebars, SidebarProcessorParams} from './processor';
+import {processSidebars, type SidebarProcessorParams} from './processor';
 import path from 'path';
 import {createSlugger} from '@docusaurus/utils';
 

packages/docusaurus-plugin-content-docs/src/sidebars/processor.ts

@@ -30,7 +30,7 @@ import {DefaultSidebarItemsGenerator} from './generator';
 import {mapValues, memoize, pick} from 'lodash';
 import combinePromises from 'combine-promises';
 import {normalizeItem} from './normalization';
-import {Slugger} from '@docusaurus/utils';
+import type {Slugger} from '@docusaurus/utils';
 
 export type SidebarProcessorParams = {
   sidebarItemsGenerator: SidebarItemsGeneratorOption;

packages/docusaurus-plugin-content-docs/src/sidebars/types.ts

@@ -5,14 +5,13 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import type {Optional} from 'utility-types';
+import type {Optional, Required} from 'utility-types';
 import type {
   DocMetadataBase,
   VersionMetadata,
   NumberPrefixParser,
   SidebarOptions,
 } from '../types';
-import {Required} from 'utility-types';
 
 // Makes all properties visible when hovering over the type
 type Expand<T extends Record<string, unknown>> = {[P in keyof T]: T[P]};

packages/docusaurus-plugin-content-docs/src/sidebars/utils.ts

@@ -15,17 +15,15 @@ import type {
   SidebarItemType,
   SidebarCategoriesShorthand,
   SidebarItemConfig,
-} from './types';
-
-import {mapValues, difference, uniq} from 'lodash';
-import {getElementsAround, toMessageRelativeFilePath} from '@docusaurus/utils';
-import {DocMetadataBase, DocNavLink} from '../types';
-import {
   SidebarItemCategoryWithGeneratedIndex,
   SidebarItemCategoryWithLink,
   SidebarNavigationItem,
 } from './types';
 
+import {mapValues, difference, uniq} from 'lodash';
+import {getElementsAround, toMessageRelativeFilePath} from '@docusaurus/utils';
+import type {DocMetadataBase, DocNavLink} from '../types';
+
 export function isCategoriesShorthand(
   item: SidebarItemConfig,
 ): item is SidebarCategoriesShorthand {

packages/docusaurus-plugin-content-docs/src/sidebars/validation.ts

@@ -20,7 +20,7 @@ import type {
   SidebarItemCategoryLinkGeneratedIndex,
 } from './types';
 import {isCategoriesShorthand} from './utils';
-import {CategoryMetadataFile} from './generator';
+import type {CategoryMetadataFile} from './generator';
 
 const sidebarItemBaseSchema = Joi.object<SidebarItemBase>({
   className: Joi.string(),