3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-04 12:47:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(theme): <Admonition> should render properly without heading/icon (#10080)

Browse source
This commit is contained in:
Andrea Mazzucchelli 2024-04-30 14:28:58 +02:00 • committed by GitHub
parent 3ee776050e
commit c967ea5b4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/docusaurus-theme-classic/src/theme/Admonition/Layout/index.tsx
View file

@ -50,7 +50,7 @@ export default function AdmonitionLayout(props: Props): JSX.Element {
const {type, icon, title, children, className} = props; const {type, icon, title, children, className} = props;
return ( return (
<AdmonitionContainer type={type} className={className}> <AdmonitionContainer type={type} className={className}>
<AdmonitionHeading title={title} icon={icon} /> {title || icon ? <AdmonitionHeading title={title} icon={icon} /> : null}
<AdmonitionContent>{children}</AdmonitionContent> <AdmonitionContent>{children}</AdmonitionContent>
</AdmonitionContainer> </AdmonitionContainer>
); );

14
website/_dogfooding/_pages tests/markdown-tests-mdx.mdx
View file

@ -333,6 +333,20 @@ test
:::: ::::
```mdx-code-block
import Admonition from '@theme/Admonition';
export function AdmonitionWithoutHeading(props) {
return (
<Admonition {...props} type="info" icon={null} title={null}>
Admonition content without heading
</Admonition>
);
}
```
<AdmonitionWithoutHeading />
## Linking ## Linking
This is a test page to see if Docusaurus Markdown features are working properly This is a test page to see if Docusaurus Markdown features are working properly