refactor: fix a lot of errors in type-aware linting (#7477)

packages/docusaurus-theme-common/src/components/Collapsible/index.tsx

@@ -27,7 +27,7 @@ export function useCollapsible({
   initialState,
 }: {
   /** The initial state. Will be non-collapsed by default. */
-  initialState: boolean | (() => boolean);
+  initialState?: boolean | (() => boolean);
 }): {
   collapsed: boolean;
   setCollapsed: Dispatch<SetStateAction<boolean>>;

packages/docusaurus-theme-common/src/hooks/useSkipToContent.ts

@@ -40,7 +40,7 @@ export function useSkipToContent(): {
     e.preventDefault();
 
     const targetElement: HTMLElement | null =
-      document.querySelector('main:first-of-type') ||
+      document.querySelector('main:first-of-type') ??
       document.querySelector(`.${ThemeClassNames.wrapper.main}`);
 
     if (targetElement) {

packages/docusaurus-theme-common/src/hooks/useTOCHighlight.ts

@@ -38,15 +38,12 @@ function getAnchors({
 }: {
   minHeadingLevel: number;
   maxHeadingLevel: number;
-}) {
+}): HTMLElement[] {
   const selectors = [];
   for (let i = minHeadingLevel; i <= maxHeadingLevel; i += 1) {
     selectors.push(`h${i}.anchor`);
   }
-
-  return Array.from(
-    document.querySelectorAll(selectors.join()),
-  ) as HTMLElement[];
+  return Array.from(document.querySelectorAll(selectors.join()));
 }
 
 function getActiveAnchor(

packages/docusaurus-theme-common/src/utils/codeBlockUtils.ts

@@ -171,7 +171,7 @@ export function parseLines(
     const metastringRangeClassName = magicComments[0]!.className;
     const lines = rangeParser(linesRange)
       .filter((n) => n > 0)
-      .map((n) => [n - 1, [metastringRangeClassName]]);
+      .map((n) => [n - 1, [metastringRangeClassName]] as [number, string[]]);
     return {lineClassNames: Object.fromEntries(lines), code};
   }
   if (language === undefined) {
@@ -189,7 +189,7 @@ export function parseLines(
   const lineToClassName: {[comment: string]: string} = Object.fromEntries(
     magicComments
       .filter((d) => d.line)
-      .map(({className, line}) => [line, className]),
+      .map(({className, line}) => [line!, className] as [string, string]),
   );
   const blockStartToClassName: {[comment: string]: string} = Object.fromEntries(
     magicComments

packages/docusaurus-theme-common/src/utils/reactUtils.tsx

@@ -70,7 +70,7 @@ export class ReactContextError extends Error {
     this.name = 'ReactContextError';
     this.message = `Hook ${
       this.stack?.split('\n')[1]?.match(/at (?:\w+\.)?(?<name>\w+)/)?.groups!
-        .name
+        .name ?? ''
     } is called outside the <${providerName}>. ${additionalInfo || ''}`;
   }
 }

packages/docusaurus-theme-common/src/utils/routesUtils.ts

@@ -18,7 +18,7 @@ export function isSamePath(
   path2: string | undefined,
 ): boolean {
   const normalize = (pathname: string | undefined) =>
-    (!pathname || pathname?.endsWith('/')
+    (!pathname || pathname.endsWith('/')
       ? pathname
       : `${pathname}/`
     )?.toLowerCase();

packages/docusaurus-theme-common/src/utils/scrollUtils.tsx

@@ -112,11 +112,7 @@ export function useScrollPosition(
         return;
       }
       const currentPosition = getScrollPosition()!;
-
-      if (dynamicEffect) {
-        dynamicEffect(currentPosition, lastPositionRef.current);
-      }
-
+      dynamicEffect(currentPosition, lastPositionRef.current);
       lastPositionRef.current = currentPosition;
     };
 

packages/docusaurus-theme-common/src/utils/searchUtils.ts

@@ -39,7 +39,7 @@ export function useContextualSearchFilters(): {locale: string; tags: string[]} {
   // plugin instances.
   function getDocPluginTags(pluginId: string) {
     const activeVersion =
-      activePluginAndVersion?.activePlugin?.pluginId === pluginId
+      activePluginAndVersion?.activePlugin.pluginId === pluginId
         ? activePluginAndVersion.activeVersion
         : undefined;
 

packages/docusaurus-theme-common/src/utils/tocUtils.ts

@@ -27,7 +27,7 @@ function treeifyTOC(flatTOC: readonly TOCItem[]): TOCTreeNode[] {
   // level <i>. We will modify these indices as we iterate through all headings.
   // e.g. if an ### H3 was last seen at index 2, then prevIndexForLevel[3] === 2
   // indices 0 and 1 will remain unused.
-  const prevIndexForLevel = Array(7).fill(-1);
+  const prevIndexForLevel = Array<number>(7).fill(-1);
 
   headings.forEach((curr, currIndex) => {
     // Take the last seen index for each ancestor level. the highest index will

packages/docusaurus-theme-common/src/utils/usePluralForm.ts

@@ -95,7 +95,11 @@ function selectPluralMessage(
   }
   if (parts.length > localePluralForms.pluralForms.length) {
     console.error(
-      `For locale=${localePluralForms.locale}, a maximum of ${localePluralForms.pluralForms.length} plural forms are expected (${localePluralForms.pluralForms}), but the message contains ${parts.length}: ${pluralMessages}`,
+      `For locale=${localePluralForms.locale}, a maximum of ${
+        localePluralForms.pluralForms.length
+      } plural forms are expected (${localePluralForms.pluralForms.join(
+        ',',
+      )}), but the message contains ${parts.length}: ${pluralMessages}`,
     );
   }
   const pluralForm = localePluralForms.select(count);