From ab58eaa9fa0a7590b5949d7e453ade056bf67273 Mon Sep 17 00:00:00 2001
From: Frank Li <frankli1@fb.com>
Date: Tue, 25 Jul 2017 16:30:49 -0700
Subject: [PATCH] Update use of readCategories.js

---
 lib/core/DocsSidebar.js      |  3 ++-
 lib/server/generate.js       | 10 ----------
 lib/server/readCategories.js | 10 +---------
 lib/server/server.js         | 18 +++---------------
 4 files changed, 6 insertions(+), 35 deletions(-)

diff --git a/lib/core/DocsSidebar.js b/lib/core/DocsSidebar.js
index 3a58f01b37..037490c26a 100644
--- a/lib/core/DocsSidebar.js
+++ b/lib/core/DocsSidebar.js
@@ -12,11 +12,12 @@ const React = require("react");
 const Container = require("./Container.js");
 const SideNav = require("./nav/SideNav.js");
 const siteConfig = require(process.cwd() + "/siteConfig.js");
+const readCategories = require("../server/readCategories.js");
 
 class DocsSidebar extends React.Component {
   render() {
     let layout = this.props.metadata.layout;
-    let docsCategories = require("./" + layout + "Categories.js");
+    let docsCategories = readCategories(layout);
     return (
       <Container className="docsNavContainer" id="docsNav" wrapper={false}>
         <SideNav
diff --git a/lib/server/generate.js b/lib/server/generate.js
index f91ac75ae3..6d78c0b0d3 100644
--- a/lib/server/generate.js
+++ b/lib/server/generate.js
@@ -86,16 +86,6 @@ function execute() {
       "/" + siteConfig.projectName + "/" + metadata.permalink;
   }
 
-  const readCategories = require("./readCategories.js");
-  let layouts = {};
-  for (let i = 0; i < Metadata.length; i++) {
-    let layout = Metadata[i].layout;
-    if (layouts[layout] !== true) {
-      layouts[layout] = true;
-      readCategories(layout);
-    }
-  }
-
   const DocsLayout = require("../core/DocsLayout.js");
 
   fs.removeSync(__dirname + "/../../build");
diff --git a/lib/server/readCategories.js b/lib/server/readCategories.js
index bc56da7518..49d5d0860c 100644
--- a/lib/server/readCategories.js
+++ b/lib/server/readCategories.js
@@ -90,15 +90,7 @@ function readCategories(layout) {
     allCategories[language] = categories;
   }
 
-  fs.writeFileSync(
-    __dirname + "/../core/" + layout + "Categories.js",
-    "/**\n" +
-      " * @generated\n" +
-      " */\n" +
-      "module.exports = " +
-      JSON.stringify(allCategories, null, 2) +
-      ";"
-  );
+  return allCategories;
 }
 
 module.exports = readCategories;
diff --git a/lib/server/server.js b/lib/server/server.js
index 510e8cbc3d..cdc1645b42 100644
--- a/lib/server/server.js
+++ b/lib/server/server.js
@@ -71,23 +71,11 @@ function execute(port) {
   /****************************************************************************/
 
   let Metadata;
-  let readCategories;
 
-  function reloadMetadataCategories() {
+  function reloadMetadata() {
     readMetadata.generateDocsMetadata();
     purgeCache("../core/metadata.js");
     Metadata = require("../core/metadata.js");
-    purgeCache("./readCategories.js");
-    readCategories = require("./readCategories.js");
-
-    let layouts = {};
-    for (let i = 0; i < Metadata.length; i++) {
-      let layout = Metadata[i].layout;
-      if (layouts[layout] !== true) {
-        layouts[layout] = true;
-        readCategories(layout);
-      }
-    }
   }
 
   /****************************************************************************/
@@ -127,7 +115,7 @@ function execute(port) {
 
   console.log("server.js triggered...");
 
-  reloadMetadataCategories();
+  reloadMetadata();
 
   /* handle all requests for document pages */
   const app = express().get(/docs\/[\s\S]*html$/, (req, res, next) => {
@@ -136,7 +124,7 @@ function execute(port) {
 
     console.log(req.path);
 
-    reloadMetadataCategories();
+    reloadMetadata();
     let links = {};
     for (let i = 0; i < Metadata.length; i++) {
       const metadata = Metadata[i];