refactor: improve types (#6866)

This commit is contained in:
Joshua Chen 2022-03-07 22:14:50 +08:00 committed by GitHub
parent 8e934450d8
commit a4e37c4054
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 50 deletions

View file

@ -23,16 +23,7 @@ export default function preload(
const matches = matchRoutes(routes, pathname);
return Promise.all(
matches.map((match) => {
const {component} = match.route;
// @ts-expect-error: ComponentCreator injected this method.
if (component && component.preload) {
// @ts-expect-error: checked above.
return component.preload();
}
return undefined;
}),
// @ts-expect-error: ComponentCreator injected this method.
matches.map((match) => match.route.component?.preload?.()),
);
}

View file

@ -236,15 +236,20 @@ export function applyConfigurePostCss(
return config;
}
declare global {
interface Error {
/** @see https://webpack.js.org/api/node/#error-handling */
details: unknown;
}
}
export function compile(config: Configuration[]): Promise<void> {
return new Promise((resolve, reject) => {
const compiler = webpack(config);
compiler.run((err, stats) => {
if (err) {
logger.error(err.stack || err);
// @ts-expect-error: see https://webpack.js.org/api/node/#error-handling
if (err.details) {
// @ts-expect-error: see https://webpack.js.org/api/node/#error-handling
logger.error(err.details);
}
reject(err);