3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-20 12:37:01 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(v2): convert synchronous file write to asynchronous (#2936)

Browse source 
* perf(v2): convert synchronous filewrite to asynchronous in feed file generate

This looks like should return a Promise list , other than a sync io operation

* perf(v2): convert synchronous filewrite to asynchronous in sitemap generate

* perf(v2): convert  Promise style to async/await style

for consistency
This commit is contained in:
moonrailgun 2020-06-15 22:04:15 +08:00 • committed by GitHub
parent 0c92f5aacd
commit 930222ea87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/docusaurus-plugin-content-blog/src/index.ts
View file

@ -441,7 +441,7 @@ export default function pluginContentBlog(
const feedTypes = getFeedTypes(options.feedOptions?.type); const feedTypes = getFeedTypes(options.feedOptions?.type);
await Promise.all( await Promise.all(
feedTypes.map((feedType) => { feedTypes.map(async (feedType) => {
const feedPath = path.join( const feedPath = path.join(
outDir, outDir,
options.routeBasePath, options.routeBasePath,
@ -449,7 +449,7 @@ export default function pluginContentBlog(
); );
const feedContent = feedType === 'rss' ? feed.rss2() : feed.atom1(); const feedContent = feedType === 'rss' ? feed.rss2() : feed.atom1();
try { try {
fs.writeFileSync(feedPath, feedContent); await fs.outputFile(feedPath, feedContent);
} catch (err) { } catch (err) {
throw new Error(`Generating ${feedType} feed failed: ${err}`); throw new Error(`Generating ${feedType} feed failed: ${err}`);
} }

4
packages/docusaurus-plugin-sitemap/src/index.ts
View file

@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
import fs from 'fs'; import fs from 'fs-extra';
import path from 'path'; import path from 'path';
import {PluginOptions} from './types'; import {PluginOptions} from './types';
import createSitemap from './createSitemap'; import createSitemap from './createSitemap';
@ -37,7 +37,7 @@ export default function pluginSitemap(
// Write sitemap file. // Write sitemap file.
const sitemapPath = path.join(outDir, 'sitemap.xml'); const sitemapPath = path.join(outDir, 'sitemap.xml');
try { try {
fs.writeFileSync(sitemapPath, generatedSitemap); await fs.outputFile(sitemapPath, generatedSitemap);
} catch (err) { } catch (err) {
throw new Error(`Sitemap error: ${err}`); throw new Error(`Sitemap error: ${err}`);
} }