From 8242c0eb008305ca6c7fd26e578e111e21cc3aa9 Mon Sep 17 00:00:00 2001 From: Endi Date: Wed, 13 Nov 2019 15:01:04 +0700 Subject: [PATCH] perf(v2): reduce main bundle size by using es5 if possible (#1979) --- packages/docusaurus/src/client/PendingNavigation.js | 2 +- packages/docusaurus/src/client/docusaurus.js | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/docusaurus/src/client/PendingNavigation.js b/packages/docusaurus/src/client/PendingNavigation.js index 718431b979..0e231ebd3d 100644 --- a/packages/docusaurus/src/client/PendingNavigation.js +++ b/packages/docusaurus/src/client/PendingNavigation.js @@ -63,7 +63,7 @@ class PendingNavigation extends React.Component { if (!hash) { window.scrollTo(0, 0); } else { - const id = hash.replace('#', ''); + const id = hash.substring(1); const element = document.getElementById(id); if (element) element.scrollIntoView(); } diff --git a/packages/docusaurus/src/client/docusaurus.js b/packages/docusaurus/src/client/docusaurus.js index 51e2b86b6f..379c5237a6 100644 --- a/packages/docusaurus/src/client/docusaurus.js +++ b/packages/docusaurus/src/client/docusaurus.js @@ -18,7 +18,7 @@ const isSlowConnection = () => { // if user is on slow or constrained connection if (`connection` in navigator) { if ( - (navigator.connection.effectiveType || ``).includes(`2g`) && + (navigator.connection.effectiveType || ``).indexOf(`2g`) !== -1 && navigator.connection.saveData ) { return true; @@ -55,8 +55,7 @@ const docusaurus = { const chunkAssets = window.__chunkMapping[chunkName] || []; return arr.concat(chunkAssets); }, []); - const dedupedChunkAssets = Array.from(new Set(chunkAssetsNeeded)); - Promise.all(dedupedChunkAssets.map(prefetchHelper)).then(() => { + Promise.all(chunkAssetsNeeded.map(prefetchHelper)).then(() => { fetched[routePath] = true; }); return true;