fix(v2): classic theme - semantic correct anchors links (#5080)

* fix(v2): semantic correct anchors

* chore: ignore linting
This commit is contained in:
Adam Uhlíř 2021-06-30 15:24:03 +02:00 committed by GitHub
parent c3127b65d1
commit 823b020c34
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View file

@ -128,6 +128,7 @@ function DocSidebarItemCategory({
className={clsx('menu__list-item', {
'menu__list-item--collapsed': collapsed,
})}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<a
className={clsx('menu__link', {
'menu__link--sublist': collapsible,
@ -135,7 +136,7 @@ function DocSidebarItemCategory({
[styles.menuLinkText]: !collapsible,
})}
onClick={collapsible ? handleItemClick : undefined}
href={collapsible ? '#!' : undefined}
href={collapsible ? '#' : undefined}
{...props}>
{label}
</a>

View file

@ -41,7 +41,8 @@ function SkipToContent(): JSX.Element {
return (
<div ref={containerRef}>
<a href="#main" className={styles.skipToContent} onClick={handleSkip}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<a href="#" className={styles.skipToContent} onClick={handleSkip}>
<Translate
id="theme.common.skipToMainContent"
description="The skip to content label used for accessibility, allowing to rapidly navigate to main content with keyboard tab/enter navigation">