refactor(pwa): simplify registerSW code, fix ESLint errors (#7579)

This commit is contained in:
Joshua Chen 2022-06-07 21:42:17 +08:00 committed by GitHub
parent bada5c11cc
commit 7869e74fd7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 204 additions and 247 deletions

View file

@ -141,18 +141,17 @@ const aliases = {
warning: 'danger',
} as const;
function getAdmonitionConfig(
unsafeType: Props['type'] | keyof typeof aliases,
): AdmonitionConfig {
const type = aliases[unsafeType as keyof typeof aliases] ?? unsafeType;
const config = AdmonitionConfigs[type];
function getAdmonitionConfig(unsafeType: string): AdmonitionConfig {
const type =
(aliases as {[key: string]: Props['type']})[unsafeType] ?? unsafeType;
const config = (AdmonitionConfigs as {[key: string]: AdmonitionConfig})[type];
if (config) {
return config;
}
console.warn(
`No admonition config found for admonition type "${type}". Using Info as fallback.`,
);
return AdmonitionConfigs.info as AdmonitionConfig;
return AdmonitionConfigs.info;
}
// Workaround because it's difficult in MDX v1 to provide a MDX title as props