3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-10 23:57:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(utils): fix Markdown link replacement when link text is same as href (#7464)

Browse source
This commit is contained in:
Joshua Chen 2022-05-22 19:13:28 +08:00 • committed by GitHub
parent 5207e25291
commit 6e62bba30f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/docusaurus-utils/src/__tests__/__snapshots__/markdownLinks.test.ts.snap
View file

@ -102,10 +102,10 @@ exports[`replaceMarkdownLinks replaces links with same title as URL 1`] = `
{
"brokenMarkdownLinks": [],
"newContent": "
[/docs/foo](foo.md)
[/docs/foo](./foo.md)
[foo.md](/docs/foo)
[.//docs/foo](foo.md)
[./foo.md](/docs/foo)
[foo.md](/docs/foo)
[./foo.md](/docs/foo)
",
}
`;

1
packages/docusaurus-utils/src/__tests__/markdownLinks.test.ts
View file

@ -204,7 +204,6 @@ The following operations are defined for [URI]s:
).toMatchSnapshot();
});
// FIXME
it('replaces links with same title as URL', () => {
expect(
replaceMarkdownLinks({

5
packages/docusaurus-utils/src/markdownLinks.ts
View file

@ -137,7 +137,10 @@ export function replaceMarkdownLinks<T extends ContentPaths>({
.split('/')
.map((part) => part.replace(/\s/g, '%20'))
.join('/');
modifiedLine = modifiedLine.replace(mdLink, encodedPermalink);
modifiedLine = modifiedLine.replace(
mdMatch[0]!,
mdMatch[0]!.replace(mdLink, encodedPermalink),
);
// Adjust the lastIndex to avoid passing over the next link if the
// newly replaced URL is shorter.
mdRegex.lastIndex += encodedPermalink.length - mdLink.length;