3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-08-02 08:19:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor: fix more type-aware linting errors (#7479)

Browse source
This commit is contained in:
Joshua Chen 2022-05-24 19:19:24 +08:00 • committed by GitHub
parent bf1513a3e3
commit 624735bd92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
51 changed files with 192 additions and 189 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/docusaurus-theme-common/src/components/Details/index.tsx
View file

@ -92,7 +92,7 @@ export function Details({
}
}}>
{/* eslint-disable-next-line @docusaurus/no-untranslated-text */}
{summary || <summary>Details</summary>}
{summary ?? <summary>Details</summary>}
<Collapsible
lazy={false} // Content might matter for SEO in this case

2
packages/docusaurus-theme-common/src/hooks/useTOCHighlight.ts
View file

@ -151,7 +151,7 @@ export function useTOCHighlight(config: TOCHighlightConfig | undefined): void {
function updateLinkActiveClass(link: HTMLAnchorElement, active: boolean) {
if (active) {
if (lastActiveLinkRef.current && lastActiveLinkRef.current !== link) {
lastActiveLinkRef.current?.classList.remove(linkActiveClassName);
lastActiveLinkRef.current.classList.remove(linkActiveClassName);
}
link.classList.add(linkActiveClassName);
lastActiveLinkRef.current = link;

6
packages/docusaurus-theme-common/src/utils/codeBlockUtils.ts
View file

@ -97,7 +97,7 @@ export function parseCodeBlockTitle(metastring?: string): string {
}
export function containsLineNumbers(metastring?: string): boolean {
return metastring?.includes('showLineNumbers') || false;
return Boolean(metastring?.includes('showLineNumbers'));
}
/**
@ -209,7 +209,9 @@ export function parseLines(
lineNumber += 1;
continue;
}
const directive = match.slice(1).find((item) => item !== undefined)!;
const directive = match
.slice(1)
.find((item: string | undefined) => item !== undefined)!;
if (lineToClassName[directive]) {
blocks[lineToClassName[directive]!]!.range += `${lineNumber},`;
} else if (blockStartToClassName[directive]) {

6
packages/docusaurus-theme-common/src/utils/useThemeConfig.ts
View file

@ -85,10 +85,10 @@ export type FooterBase = {
};
export type MultiColumnFooter = FooterBase & {
links: Array<{
links: {
title: string | null;
items: FooterLinkItem[];
}>;
}[];
};
export type SimpleFooter = FooterBase & {
@ -123,7 +123,7 @@ export type ThemeConfig = {
prism: PrismConfig;
footer?: Footer;
image?: string;
metadata: Array<{[key: string]: string}>;
metadata: {[key: string]: string}[];
tableOfContents: TableOfContents;
};