fix(v2): do not show categories with empty items (#1891)

CHANGELOG-2.x.md

@@ -9,6 +9,7 @@
 - Fix search bar focus bug. When you put the focus on search input, previously the focus will remain although we have clicked to other area outside of the search input.
 - New themeConfig option `sidebarCollapsible`. It is on by default. If explicitly set to `false`, all doc items in sidebar is expanded. Otherwise, it will still be a collapsible sidebar.
 - Disable adding hashes to the generated class names of CSS modules in dev mode. Generating unique identifiers takes some time, which can be saved since including paths to files in class names is enough to avoid collisions.
+- Fix showing sidebar category with empty items.
 
 ## 2.0.0-alpha.30
 

packages/docusaurus-theme-classic/src/theme/DocSidebar/index.js

@@ -30,31 +30,35 @@ function DocSidebarItem({item, onItemClick, collapsible}) {
   switch (type) {
     case 'category':
       return (
-        <li
+        items.length > 0 && (
-          className={classnames('menu__list-item', {
+          <li
-            'menu__list-item--collapsed': collapsed,
+            className={classnames('menu__list-item', {
-          })}
+              'menu__list-item--collapsed': collapsed,
-          key={label}>
-          <a
-            className={classnames('menu__link', {
-              'menu__link--sublist': collapsible,
-              'menu__link--active': collapsible && !item.collapsed,
             })}
-            href="#!"
+            key={label}>
-            onClick={collapsible ? () => setCollapsed(!collapsed) : undefined}>
+            <a
-            {label}
+              className={classnames('menu__link', {
-          </a>
+                'menu__link--sublist': collapsible,
-          <ul className="menu__list">
+                'menu__link--active': collapsible && !item.collapsed,
-            {items.map(childItem => (
+              })}
-              <DocSidebarItem
+              href="#!"
-                key={childItem.label}
+              onClick={
-                item={childItem}
+                collapsible ? () => setCollapsed(!collapsed) : undefined
-                onItemClick={onItemClick}
+              }>
-                collapsible={collapsible}
+              {label}
-              />
+            </a>
-            ))}
+            <ul className="menu__list">
-          </ul>
+              {items.map(childItem => (
-        </li>
+                <DocSidebarItem
+                  key={childItem.label}
+                  item={childItem}
+                  onItemClick={onItemClick}
+                  collapsible={collapsible}
+                />
+              ))}
+            </ul>
+          </li>
+        )
       );
 
     case 'link':
@@ -164,16 +168,19 @@ function DocSidebar(props) {
           )}
         </button>
         <ul className="menu__list">
-          {sidebarData.map(item => (
+          {sidebarData.map(
-            <DocSidebarItem
+            item =>
-              key={item.label}
+              item.items.length > 0 && (
-              item={item}
+                <DocSidebarItem
-              onItemClick={() => {
+                  key={item.label}
-                setShowResponsiveSidebar(false);
+                  item={item}
-              }}
+                  onItemClick={() => {
-              collapsible={sidebarCollapsible}
+                    setShowResponsiveSidebar(false);
-            />
+                  }}
-          ))}
+                  collapsible={sidebarCollapsible}
+                />
+              ),
+          )}
         </ul>
       </div>
     </div>