From 54e4b0266667c53c0b46cba25cd9991c74b2bbcf Mon Sep 17 00:00:00 2001 From: Alexey Pyltsyn Date: Fri, 16 Jul 2021 12:56:00 +0300 Subject: [PATCH] fix(v2): add base URL to content attribute of head tags PWA (#5185) --- packages/docusaurus-plugin-pwa/src/index.js | 18 +++++++++++++++--- website/docusaurus.config.js | 2 +- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/packages/docusaurus-plugin-pwa/src/index.js b/packages/docusaurus-plugin-pwa/src/index.js index 5e4ce875d6..232399ae96 100644 --- a/packages/docusaurus-plugin-pwa/src/index.js +++ b/packages/docusaurus-plugin-pwa/src/index.js @@ -90,9 +90,21 @@ function plugin(context, options) { const headTags = []; if (isProd && pwaHead) { pwaHead.forEach(({tagName, ...attributes}) => { - if (attributes.href && !attributes.href.startsWith(baseUrl)) { - attributes.href = normalizeUrl([baseUrl, attributes.href]); - } + ['href', 'content'].forEach((attribute) => { + const attributeValue = attributes[attribute]; + + if (!attributeValue) { + return; + } + + const attributePath = + !!path.extname(attributeValue) && attributeValue; + + if (attributePath && !attributePath.startsWith(baseUrl)) { + attributes[attribute] = normalizeUrl([baseUrl, attributeValue]); + } + }); + return headTags.push({ tagName, attributes, diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js index 6d18b5e306..54cd39da64 100644 --- a/website/docusaurus.config.js +++ b/website/docusaurus.config.js @@ -232,7 +232,7 @@ const isVersioningDisabled = !!process.env.DISABLE_VERSIONING || isI18nStaging; { tagName: 'meta', name: 'msapplication-TileImage', - href: 'img/docusaurus.png', + content: 'img/docusaurus.png', }, { tagName: 'meta',