3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-06-05 04:12:53 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): fix navigation from homepage (#4136)

Browse source
This commit is contained in:
Alexey Pyltsyn 2021-02-01 00:29:49 +03:00 • committed by GitHub
parent 30c8e26a31
commit 39edfe35aa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

16
packages/docusaurus/src/client/baseUrlIssueBanner/BaseUrlIssueBanner.tsx
View file

@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/
import React, {useLayoutEffect} from 'react';
import React from 'react';
import {useLocation} from 'react-router-dom';
import Head from '../exports/Head';
@ -63,19 +63,6 @@ document.addEventListener('DOMContentLoaded', renderBanner);
`;
}
// Normally if the baseUrl is correct, the banner will already be hidden by the critical CSS
// But we can still remove it totally from the DOM if it's not useful anymore
// This is kind of a "double security"
// It can also prevent the banner to appear if the CSS fails to load due to some network error
function useBannerRemover() {
useLayoutEffect(() => {
const banner = document.getElementById(BannerContainerId);
if (banner) {
banner.remove();
}
}, []);
}
function BaseUrlIssueBannerEnabled() {
const {
siteConfig: {baseUrl},
@ -100,7 +87,6 @@ export default function BaseUrlIssueBanner(): JSX.Element | null {
siteConfig: {baseUrl, baseUrlIssueBanner},
} = useDocusaurusContext();
const {pathname} = useLocation();
useBannerRemover();
// returns true for the homepage during SRR
const isHomePage = pathname === baseUrl;