chore: fix ci? (#10153)

.github/workflows/build-hash-router.yml

@@ -9,11 +9,15 @@ on:
       - docusaurus-v**
     paths:
       - packages/**
+      - .github/workflows/build-hash-router.yml
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 
+permissions:
+  contents: write
+
 jobs:
   build:
     name: Build Hash Router
@@ -29,34 +33,51 @@ jobs:
           cache: yarn
       - name: Installation
         run: yarn
+
       - name: Build Hash Router
         run: yarn build:website:fast
         env:
           DOCUSAURUS_ROUTER: 'hash'
-          BASE_URL: '/docusaurus/' # GH pages deploys under https://facebook.github.io/docusaurus/
+          # Note: hash router + baseUrl do not play well together
+          # This would host at https://facebook.github.io/docusaurus/#/docusaurus/
+          # BASE_URL: '/docusaurus/' # hash router +
+
       - name: Upload Website artifact
         uses: actions/upload-artifact@v4
         with:
           name: website-hash-router-archive
           path: website/build
-      - name: Upload Website Pages artifact
-        uses: actions/upload-pages-artifact@v3
-        with:
-          path: website/build
 
-  # See https://docusaurus.io/docs/deployment#triggering-deployment-with-github-actions
+      #- name: Upload Website Pages artifact
-  deploy:
+      #  uses: actions/upload-pages-artifact@v3
-    name: Deploy to GitHub Pages
+      #  with:
-    if: ${{ github.event_name != 'pull_request' && github.ref_name == 'main' }}
+      #    path: website/build
-    needs: build
+
-    permissions:
+      # Deploy to https://facebook.github.io/docusaurus/
-      pages: write
-      id-token: write
-    environment:
-      name: github-pages
-      url: ${{ steps.deployment.outputs.page_url }}
-    runs-on: ubuntu-latest
-    steps:
       - name: Deploy to GitHub Pages
-        id: deployment
+        if: ${{ github.event_name != 'pull_request' && github.ref_name == 'main' }}
-        uses: actions/deploy-pages@v4
+        uses: peaceiris/actions-gh-pages@v3
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          publish_dir: website/build
+
+  ## TODO we should be able to use this new deploy-pages action
+  ## However this requires a Meta admin to configure it here
+  ## https://github.com/facebook/docusaurus/settings/pages
+  ## So for now we keep using the former method
+  ## See https://docusaurus.io/docs/deployment#triggering-deployment-with-github-actions
+  #deploy:
+  #  name: Deploy to GitHub Pages
+  #  if: ${{ github.event_name != 'pull_request' && github.ref_name == 'main' }}
+  #  needs: build
+  #  permissions:
+  #    pages: write
+  #    id-token: write
+  #  environment:
+  #    name: github-pages
+  #    url: ${{ steps.deployment.outputs.page_url }}
+  #  runs-on: ubuntu-latest
+  #  steps:
+  #     - name: Deploy to GitHub Pages
+  #      id: deployment
+  #      uses: actions/deploy-pages@v4