From 25ba91fd4d3d0da226fe8e20ee083725b2023bd1 Mon Sep 17 00:00:00 2001
From: Joshua Chen <sidachen2003@gmail.com>
Date: Mon, 11 Apr 2022 07:43:30 +0800
Subject: [PATCH] fix(website): remove skipLibCheck (#7147)

---
 website/package.json  | 2 +-
 website/tsconfig.json | 7 ++++---
 yarn.lock             | 8 ++++----
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/website/package.json b/website/package.json
index 770af5cc78..e3e347c3a3 100644
--- a/website/package.json
+++ b/website/package.json
@@ -57,7 +57,7 @@
     "raw-loader": "^4.0.2",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
-    "react-medium-image-zoom": "^4.3.6",
+    "react-medium-image-zoom": "^4.3.7",
     "react-popper": "^2.2.5",
     "rehype-katex": "^6.0.2",
     "remark-math": "^3.0.1",
diff --git a/website/tsconfig.json b/website/tsconfig.json
index e6aa4a4407..2e797c69f6 100644
--- a/website/tsconfig.json
+++ b/website/tsconfig.json
@@ -6,9 +6,10 @@
     "baseUrl": ".",
     "resolveJsonModule": true,
     "strict": true,
-    // Work around a type error in react-medium-image-zoom.
-    // https://github.com/rpearce/image-zoom/pull/303
-    "skipLibCheck": true,
+    // This is important. We run `yarn tsc` in website so we can catch issues
+    // with our declaration files (mostly name that are forgotten to be
+    // imported). Removing this would make things harder to catch.
+    "skipLibCheck": false,
     "types": ["@types/jest"]
   },
   "exclude": ["src/sw.js"]
diff --git a/yarn.lock b/yarn.lock
index e281f527a4..2051469fd2 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -15559,10 +15559,10 @@ react-loadable-ssr-addon-v5-slorber@^1.0.1:
   dependencies:
     "@babel/runtime" "^7.10.3"
 
-react-medium-image-zoom@^4.3.6:
-  version "4.3.6"
-  resolved "https://registry.yarnpkg.com/react-medium-image-zoom/-/react-medium-image-zoom-4.3.6.tgz#75c874fa219ba1f29e23ae75f9a5affe74e9bc61"
-  integrity sha512-fIetmbdwshFahTX3WICIDZdJ+loxp/RGfax7z8ov2qdBzbBEqPveQn8U18oj+e1mQdnV2UjmY3YY035k2XPFZA==
+react-medium-image-zoom@^4.3.7:
+  version "4.3.7"
+  resolved "https://registry.npmmirror.com/react-medium-image-zoom/-/react-medium-image-zoom-4.3.7.tgz#06c0771401c6de312a85843d1feebd15641a969b"
+  integrity sha512-Vg1M8CIX1EfhfSsmNc2tHP+8KjPDo9e5/zEDaSsfeTBHI82wjEvW3Lgb4k3jdWILPZVOWhM+7QHyDaAzghlvaQ==
   dependencies:
     focus-options-polyfill "1.2.0"
     react-use "^17.2.1"