Integrate eslint & precommit to codebase (#815)

* add eslint, precommit & refactor

* fix exit code 127

* modify contributing.md & add package-lock

* use .eslintrc.js
This commit is contained in:
Endilie Yacop Sucipto 2018-07-01 12:27:31 +08:00 committed by GitHub
parent 97eaaad744
commit 21dcea2a31
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 4836 additions and 2139 deletions

View file

@ -6,7 +6,7 @@
*/
async function execute() {
const extractTranslations = require('../write-translations.js');
require('../write-translations.js');
const metadataUtils = require('./metadataUtils');
@ -15,7 +15,6 @@ async function execute() {
const fs = require('fs-extra');
const readMetadata = require('./readMetadata.js');
const path = require('path');
const color = require('color');
const getTOC = require('../core/getTOC.js');
const React = require('react');
const mkdirp = require('mkdirp');
@ -321,9 +320,11 @@ async function execute() {
// create sitemap
if (MetadataBlog.length > 0 || Object.keys(Metadata).length > 0) {
let targetFile = join(buildDir, 'sitemap.xml');
sitemap(xml => {
writeFileAndCreateFolder(targetFile, xml);
sitemap((err, xml) => {
if (!err) {
const targetFile = join(buildDir, 'sitemap.xml');
writeFileAndCreateFolder(targetFile, xml);
}
});
}
@ -454,7 +455,6 @@ async function execute() {
fs.writeFileSync(mainCss, css);
// compile/copy pages from user
let pagesArr = [];
files = glob.sync(join(CWD, 'pages', '**'));
files.forEach(file => {
// Why normalize? In case we are on Windows.