Integrate eslint & precommit to codebase (#815)

* add eslint, precommit & refactor

* fix exit code 127

* modify contributing.md & add package-lock

* use .eslintrc.js

lib/server/feed.js

@@ -5,17 +5,10 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-const fs = require('fs-extra');
-const path = require('path');
-const os = require('os');
 const Feed = require('feed');
-
-const chalk = require('chalk');
 const CWD = process.cwd();
-
 const siteConfig = require(CWD + '/siteConfig.js');
-
-const blogFolder = path.resolve('../blog/');
+const readMetadata = require('./readMetadata.js');
 const blogRootURL = siteConfig.url + siteConfig.baseUrl + 'blog';
 const siteImageURL =
   siteConfig.url + siteConfig.baseUrl + siteConfig.headerIcon;
@@ -23,17 +16,6 @@ const utils = require('../core/utils');
 
 const renderMarkdown = require('../core/renderMarkdown.js');
 
-/****************************************************************************/
-
-let readMetadata;
-let Metadata;
-
-readMetadata = require('./readMetadata.js');
-readMetadata.generateMetadataDocs();
-Metadata = require('../core/metadata.js');
-
-/****************************************************************************/
-
 module.exports = function(type) {
   console.log('feed.js triggered...');
 

lib/server/generate.js

@@ -6,7 +6,7 @@
  */
 
 async function execute() {
-  const extractTranslations = require('../write-translations.js');
+  require('../write-translations.js');
 
   const metadataUtils = require('./metadataUtils');
 
@@ -15,7 +15,6 @@ async function execute() {
   const fs = require('fs-extra');
   const readMetadata = require('./readMetadata.js');
   const path = require('path');
-  const color = require('color');
   const getTOC = require('../core/getTOC.js');
   const React = require('react');
   const mkdirp = require('mkdirp');
@@ -321,9 +320,11 @@ async function execute() {
 
   // create sitemap
   if (MetadataBlog.length > 0 || Object.keys(Metadata).length > 0) {
-    let targetFile = join(buildDir, 'sitemap.xml');
-    sitemap(xml => {
-      writeFileAndCreateFolder(targetFile, xml);
+    sitemap((err, xml) => {
+      if (!err) {
+        const targetFile = join(buildDir, 'sitemap.xml');
+        writeFileAndCreateFolder(targetFile, xml);
+      }
     });
   }
 
@@ -454,7 +455,6 @@ async function execute() {
   fs.writeFileSync(mainCss, css);
 
   // compile/copy pages from user
-  let pagesArr = [];
   files = glob.sync(join(CWD, 'pages', '**'));
   files.forEach(file => {
     // Why normalize? In case we are on Windows.

lib/server/readMetadata.js

@@ -10,7 +10,6 @@ const CWD = process.cwd();
 const path = require('path');
 const fs = require('fs');
 const glob = require('glob');
-const chalk = require('chalk');
 
 const metadataUtils = require('./metadataUtils');
 
@@ -180,8 +179,6 @@ function generateMetadataDocs() {
   const docsDir = path.join(CWD, '../', getDocsPath());
   let files = glob.sync(CWD + '/../' + getDocsPath() + '/**');
   files.forEach(file => {
-    let language = 'en';
-
     const extension = path.extname(file);
 
     if (extension === '.md' || extension === '.markdown') {
@@ -359,7 +356,7 @@ function generateMetadataBlog() {
     });
 
   const sortedMetadatas = metadatas.sort(
-    (a, b) => parseInt(b.seconds) - parseInt(a.seconds)
+    (a, b) => parseInt(b.seconds, 10) - parseInt(a.seconds, 10)
   );
 
   fs.writeFileSync(

lib/server/server.js

@@ -11,14 +11,11 @@ function execute(port, options) {
   const metadataUtils = require('./metadataUtils');
 
   const env = require('./env.js');
-  const translation = require('./translation');
   const express = require('express');
   const React = require('react');
   const request = require('request');
   const fs = require('fs-extra');
-  const os = require('os');
   const path = require('path');
-  const color = require('color');
   const getTOC = require('../core/getTOC');
   const {
     blogRouting,
@@ -284,10 +281,13 @@ function execute(port, options) {
   });
 
   app.get(sitemapRouting(siteConfig.baseUrl), (req, res) => {
-    res.set('Content-Type', 'application/xml');
-
-    sitemap(xml => {
-      res.send(xml);
+    sitemap((err, xml) => {
+      if (err) {
+        res.status(500).send('Sitemap error');
+      } else {
+        res.set('Content-Type', 'application/xml');
+        res.send(xml);
+      }
     });
   });
 

lib/server/sitemap.js

@@ -6,11 +6,7 @@
  */
 
 const fs = require('fs-extra');
-const path = require('path');
-const os = require('os');
-const Feed = require('feed');
 
-const chalk = require('chalk');
 const glob = require('glob');
 const CWD = process.cwd();
 
@@ -104,9 +100,6 @@ module.exports = function(callback) {
   });
 
   sm.toXML((err, xml) => {
-    if (err) {
-      return 'An error has occurred.';
-    }
-    callback(xml);
+    callback(err, xml);
   });
 };

lib/server/versionFallback.js

@@ -9,7 +9,6 @@ const CWD = process.cwd();
 const glob = require('glob');
 const fs = require('fs');
 const path = require('path');
-const assert = require('assert');
 
 const metadataUtils = require('./metadataUtils');