3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-05-19 20:17:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): Allow footer logo at attribute to be empty (#3817)

Browse source
This commit is contained in:
Aarón García Hervás 2020-11-25 13:12:45 +01:00 • committed by GitHub
parent d25a54f61d
commit 1fafdb0d33
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

20
packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.js
View file

@ -198,6 +198,26 @@ describe('themeConfig', () => {
});
});
test('should allow empty alt tags for the logo image in the footer', () => {
const partialConfig = {
footer: {
logo: {
alt: '',
src: '/arbitrary-logo.png',
},
},
};
const normalizedConfig = testValidateThemeConfig(partialConfig);
expect(normalizedConfig).toEqual({
...normalizedConfig,
footer: {
...normalizedConfig.footer,
...partialConfig.footer,
},
});
});
test('should accept valid prism config', () => {
const prismConfig = {
prism: {

2
packages/docusaurus-theme-classic/src/validateThemeConfig.js
View file

@ -254,7 +254,7 @@ const ThemeConfigSchema = Joi.object({
footer: Joi.object({
style: Joi.string().equal('dark', 'light').default('light'),
logo: Joi.object({
alt: Joi.string(),
alt: Joi.string().allow(''),
src: Joi.string(),
href: Joi.string(),
}),