refactor: enforce named capture groups; clean up regexes (#6524)

* refactor: enforce named capture groups; clean up regexes

* fixes

* fix

packages/docusaurus-plugin-content-docs/src/index.ts

@@ -333,7 +333,7 @@ export default async function pluginContentDocs(
       function createMDXLoaderRule(): RuleSetRule {
         const contentDirs = versionsMetadata.flatMap(getDocsDirPaths);
         return {
-          test: /(\.mdx?)$/,
+          test: /\.mdx?$/i,
           include: contentDirs
             // Trailing slash is important, see https://github.com/facebook/docusaurus/pull/3970
             .map(addTrailingPathSeparator),

packages/docusaurus-plugin-content-docs/src/lastUpdate.ts

@@ -10,7 +10,7 @@ import logger from '@docusaurus/logger';
 
 type FileLastUpdateData = {timestamp?: number; author?: string};
 
-const GIT_COMMIT_TIMESTAMP_AUTHOR_REGEX = /^(\d+),(.+)$/;
+const GIT_COMMIT_TIMESTAMP_AUTHOR_REGEX = /^(?<timestamp>\d+),(?<author>.+)$/;
 
 let showedGitRequirementError = false;
 
@@ -25,10 +25,10 @@ export async function getFileLastUpdate(
       return null;
     }
 
-    const temp = str.match(GIT_COMMIT_TIMESTAMP_AUTHOR_REGEX);
-    return !temp || temp.length < 3
-      ? null
-      : {timestamp: +temp[1], author: temp[2]};
+    const temp = str.match(GIT_COMMIT_TIMESTAMP_AUTHOR_REGEX)?.groups;
+    return temp
+      ? {timestamp: Number(temp.timestamp), author: temp.author}
+      : null;
   }
 
   // Wrap in try/catch in case the shell commands fail

packages/docusaurus-plugin-content-docs/src/numberPrefix.ts

@@ -11,14 +11,14 @@ import type {NumberPrefixParser} from '@docusaurus/plugin-content-docs';
 const IgnoredPrefixPatterns = (() => {
   // ignore common date-like patterns: https://github.com/facebook/docusaurus/issues/4640
   const DateLikePrefixRegex =
-    /^((\d{2}|\d{4})[-_.]\d{2}([-_.](\d{2}|\d{4}))?)(.*)$/;
+    /^(?:\d{2}|\d{4})[-_.]\d{2}(?:[-_.](?:\d{2}|\d{4}))?.*$/;
 
   // ignore common versioning patterns: https://github.com/facebook/docusaurus/issues/4653
   // note: we could try to parse float numbers in filenames but that is
   // probably not worth it as a version such as "8.0" can be interpreted as both
   // a version and a float. User can configure her own NumberPrefixParser if
   // she wants 8.0 to be interpreted as a float
-  const VersionLikePrefixRegex = /^(\d+[-_.]\d+)(.*)$/;
+  const VersionLikePrefixRegex = /^\d+[-_.]\d+.*$/;
 
   return new RegExp(
     `${DateLikePrefixRegex.source}|${VersionLikePrefixRegex.source}`,

packages/docusaurus-plugin-content-docs/src/sidebars/validation.ts

@@ -36,7 +36,7 @@ const sidebarItemAutogeneratedSchema =
     type: 'autogenerated',
     dirName: Joi.string()
       .required()
-      .pattern(/^[^/](.*[^/])?$/)
+      .pattern(/^[^/](?:.*[^/])?$/)
       .message(
         '"dirName" must be a dir path relative to the docs folder root, and should not start or end with slash',
       ),