From 14ce8c6d30e3833c952583f142c00f45a44369ce Mon Sep 17 00:00:00 2001 From: Frank Li Date: Mon, 17 Jul 2017 11:23:03 -0700 Subject: [PATCH] Make SideNav.js more readable --- lib/core/nav/SideNav.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lib/core/nav/SideNav.js b/lib/core/nav/SideNav.js index 04bcddd338..3ab9b04ec3 100644 --- a/lib/core/nav/SideNav.js +++ b/lib/core/nav/SideNav.js @@ -70,17 +70,16 @@ class SideNav extends React.Component { } getLocalizedString(metadata) { let localizedString; - if (metadata.sidebar_title) { - localizedString = translation[this.props.language] - ? translation[this.props.language]["localized-strings"][ - metadata.sidebar_title - ] || metadata.sidebar_title - : metadata.sidebar_title; + const i18n = translation[this.props.language]; + const sbTitle = metadata.sidebar_title; + + if (sbTitle) { + localizedString = i18n + ? i18n["localized-strings"][sbTitle] || sbTitle + : sbTitle; } else { - localizedString = translation[this.props.language] - ? translation[this.props.language]["localized-strings"][ - metadata.localized_id - ] || metadata.title + localizedString = i18n + ? i18n["localized-strings"][metadata.localized_id] || metadata.title : metadata.title; } return localizedString;