3pp-mirror/docusaurus
1
0
Fork 0
mirror of https://github.com/facebook/docusaurus.git synced 2025-06-03 03:12:35 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(v2): navbar items: href/to validation is too strict (not retrocompatible) (#3106)

Browse source
This commit is contained in:
Sébastien Lorber 2020-07-24 12:49:15 +02:00 • committed by GitHub
parent f926178e63
commit 0ecd71ec06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
packages/docusaurus-theme-classic/src/themeConfigSchema.js
View file

@ -9,6 +9,9 @@ const Joi = require('@hapi/joi');
const NavbarItemPosition = Joi.string().equal('left', 'right').default('left'); const NavbarItemPosition = Joi.string().equal('left', 'right').default('left');
// TODO we should probably create a custom navbar item type "dropdown"
// having this recursive structure is bad because we only support 2 levels
// + parent/child don't have exactly the same props
const DefaultNavbarItemSchema = Joi.object({ const DefaultNavbarItemSchema = Joi.object({
items: Joi.array().optional().items(Joi.link('...')), items: Joi.array().optional().items(Joi.link('...')),
to: Joi.string(), to: Joi.string(),
@ -19,7 +22,10 @@ const DefaultNavbarItemSchema = Joi.object({
activeBaseRegex: Joi.string(), activeBaseRegex: Joi.string(),
className: Joi.string(), className: Joi.string(),
'aria-label': Joi.string(), 'aria-label': Joi.string(),
}).xor('href', 'to'); });
// TODO the dropdown parent item can have no href/to
// should check should not apply to dropdown parent item
// .xor('href', 'to');
const DocsVersionNavbarItemSchema = Joi.object({ const DocsVersionNavbarItemSchema = Joi.object({
type: Joi.string().equal('docsVersion').required(), type: Joi.string().equal('docsVersion').required(),