Commit graph

4493 commits

Author SHA1 Message Date
Yann Lanthony
631fd423e0 [core] Update desc module 2024-10-30 18:46:29 +01:00
Yann Lanthony
fbba37e510 [core] Split desc module 2024-10-30 18:43:38 +01:00
Yann Lanthony
0df531c467 [core] Update desc.computation 2024-10-30 18:42:50 +01:00
Yann Lanthony
a973974373 [core] Split desc.computation 2024-10-30 18:42:20 +01:00
Yann Lanthony
82e6f65ea7 [core] Update desc.node 2024-10-30 18:41:43 +01:00
Yann Lanthony
4055d25e72 [core] Split desc.node 2024-10-30 18:41:11 +01:00
Yann Lanthony
d5c151c7db [core] Update desc.attribute 2024-10-30 18:39:31 +01:00
Yann Lanthony
027fc2cb27 [core] Split desc.attribute 2024-10-30 18:38:58 +01:00
Candice Bentéjac
35914bdb0e
Merge pull request #2586 from alicevision/fix/attributeValueChanged
Fix attribute value change propagation and callback handling
2024-10-30 16:09:43 +00:00
Fabien Servant
51cddc5af0 Creation of the sfm Checking node 2024-10-29 08:42:02 +01:00
Candice Bentéjac
66d25941f5 [pipelines] Updates tracking pipelines with new segmentation nodes
The segmentation process is now split into two nodes:
`ImageDetectionPrompt` and `ImageSegmentationBox`, which replace the
`ImageSegmentationPrompt` in the camera tracking templates.

All the nodes in the templates are also correctly realigned.
2024-10-28 15:15:46 +00:00
Yann Lanthony
4686b0d85a [core] Attribute: remove emitSignals logic on value setting
With valueChanged signal being connected outside of the
Attribute's constructor, the emitSignals logic is not required to prevent
early valueChanged propagation.
2024-10-28 12:25:15 +01:00
Yann Lanthony
8e3b9873d9 [core] Clean-up unused code 2024-10-28 12:19:04 +01:00
Yann Lanthony
3cc57f89e6 [tests] Attribute callback behavior on clearing upstream dynamic output 2024-10-28 10:33:05 +01:00
Yann Lanthony
ae9ae9b11f [core] Fix connection between uncomputed output and attribute with callback 2024-10-26 23:40:21 +02:00
Yann Lanthony
7c21595da9 [tests] Test attribute callback behavior with dynamic outputs
New test suite that focuses on testing the behavior of the attribute
changes callback system when such an attribute is connected to
an upstream dynamic output value.
2024-10-26 23:39:11 +02:00
Yann Lanthony
0231fdc1df [core] Discard nested attribute for valueChange callback lookup 2024-10-26 23:36:26 +02:00
Yann Lanthony
7fdb5cc734 [core] Handle attribute valueChanged callback at the Node level
Move the attributeChanged callback logic within Node, as this
is a Node level mecanism (callbacks being declared on the node desc).

This commit also moves the attribute valueChanged signal outside of
the Attribute's constructor.
This seems to be the root cause to undesired side-effects breaking Qt's evaluation
system, data model access and consequently Meshroom's UI.
2024-10-26 23:35:15 +02:00
Yann Lanthony
e73e8f2fd7 [tests] Attribute callback behavior with upstream compound attributes
Test value change propagation and callback trigger
for attribute connected to Group and ListAttribues.
2024-10-25 18:53:02 +02:00
Yann Lanthony
31c5a5de5f [tests] Test graph loading behavior on connected attributes with callbacks 2024-10-25 18:44:05 +02:00
Yann Lanthony
4f82fa82ce [tests] Test suite for node attributeChanged callback mechanism
Suite of tests to validate the behavior of desc.Node 'on{Attribute}Changed' behavior.
2024-10-25 12:02:49 +02:00
Yann Lanthony
5b72131930 [tests] Add graph-testing fixtures
Introduce test fixture to simplify graph testing in isolation.
2024-10-25 11:47:33 +02:00
Fabien Servant
2fecb09ceb Add animated distortion option 2024-10-23 15:17:47 +02:00
Fabien Castan
88f9d4be39
Merge pull request #2573 from alicevision/dev/panoramaDisplay
Update panorama display
2024-10-20 16:27:41 +02:00
Fabien Servant
ef5130eb85 Display panorama preview instead of full resolution 2024-10-18 10:11:47 +02:00
Fabien Servant
e23b0819f8 Enable display of contact sheets 2024-10-18 10:11:15 +02:00
Candice Bentéjac
1bcfdc1da8
Merge pull request #2572 from alicevision/fix/scenePreview
[blender] Adapt `ScenePreview`'s Blender script to pixel ratio
2024-10-18 10:01:15 +02:00
Fabien Castan
d296e6c86b
Merge pull request #2556 from alicevision/dev/generateDepth
Generate depthmaps from sfmData and mesh
2024-10-17 15:08:22 +02:00
Fabien Servant
4c76564ad5 Depth/normal map rendering nodes 2024-10-17 12:02:02 +02:00
Fabien Servant
9f41a75ad6 adapt scene preview to pixelratio 2024-10-17 10:47:21 +02:00
Fabien Castan
ea92b72529
Merge pull request #2558 from alicevision/fix/unknownNodeTemplate
[core] Node: Do not automatically upgrade unknown nodes in templates
2024-10-16 09:43:33 +02:00
Fabien Castan
9d6fdf133f
Merge pull request #2563 from alicevision/fix/minorUiFixes
[ui] Various minor UI fixes
2024-10-16 09:42:06 +02:00
Candice Bentéjac
12249de216 [GraphEditor] Stop manually editing pins based on the edge's visibility
Editing the pins manually was useful when trying to hide fully the
connection whenever there was an edge connected to an attribute that
was disabled. Disabled attributes now have a special display if they are
connected, meaning both ends of the edge do not need artificial updates.
2024-10-15 16:05:41 +02:00
Candice Bentéjac
b02a0eef88 [Viewer] SequencePlayer: Prevent null accesses
When the SequencePlayer isn't available (when QtAliceVision has not been
loaded), the `viewer` element is null. All accesses to properties of this
object should thus be prevented.
2024-10-15 16:05:40 +02:00
Candice Bentéjac
3bac0d0e37 [GraphEditor] AttributePin: Fix condition for the highlight pin display 2024-10-15 16:05:40 +02:00
Candice Bentéjac
0cddff19ed [ui] Homepage: Adjust the minimum width to correctly fit logos 2024-10-15 16:05:39 +02:00
Candice Bentéjac
e6fe84a629 [nodes] Publish: Exposed the input list of files 2024-10-15 16:05:39 +02:00
Candice Bentéjac
1fbdafebfd
Merge pull request #2568 from alicevision/fix/uiSplitView
[ui] multiple fixes related to split view and node status checks
2024-10-15 14:06:18 +01:00
Fabien Castan
2a1802f91e [ui] fix layout issue: ensure the fit is updated
Without this fix, the width side is initialize correctly but not updated
when the window is resized.
2024-10-15 15:05:20 +02:00
Fabien Castan
52ecb18471 [ui] GraphEditor: SplitView fixes 2024-10-15 15:05:19 +02:00
Fabien Castan
87efdda931 [ui] Check node is valid 2024-10-15 15:05:19 +02:00
Candice Bentéjac
d563451a53 [ui] GraphEditor: check node is valid
Only count valid nodes
2024-10-15 15:05:11 +02:00
Fabien Castan
c0d87b68da [ui] GraphEditor: minor menu wording change 2024-10-15 14:41:07 +02:00
Candice Bentéjac
bf6244e831
Merge pull request #2569 from alicevision/dev/pyavImports
[nodes] LdrToHdr: Move import of `pyalicevision` within functions
2024-10-15 13:37:28 +01:00
Candice Bentéjac
cb43fd4c27 [nodes] LdrToHdr: Remove unused Python imports 2024-10-15 12:53:38 +02:00
Candice Bentéjac
0a1b5aa1e0 [nodes] LdrToHdr: Move import of pyalicevision within functions
Since `pyalicevision`, which is provided outside of Meshroom's repository,
is now needed for all the LdrToHdr nodes, importing `pyalicevision` at
the function level rather than at the file level allows the CI to pass
even if `pyalicevision` is not available.
2024-10-15 11:59:22 +02:00
Fabien Servant @ TCS
45c72d26d6
Merge pull request #2570 from alicevision/fix/cameraInit
Change sfmData version
2024-10-15 10:45:13 +02:00
Fabien Servant @ TCS
2e5b730710
Change sfmData version 2024-10-15 10:41:19 +02:00
Candice Bentéjac
9be7c03919
Merge pull request #2567 from alicevision/fix/lightingCalibrationVisu
[nodes] `LightingCalibration`: Exclude visualization output from command line
2024-10-14 13:51:16 +01:00
Candice Bentéjac
f10cd2560b [nodes] LightingCalibration: Exclude visualization output from command line 2024-10-11 19:12:23 +02:00