Commit graph

49 commits

Author SHA1 Message Date
Fabien Castan
19d2f90554 [ui] ImageGallery: allow to visualize the list of HDR images created by LDRToHDR
Conflicts:
	meshroom/ui/reconstruction.py
2020-03-10 12:33:36 +01:00
Fabien Castan
69a1f157ac [nodes] CameraInit: remove subprocess wait (communicate is enough) 2019-12-16 20:10:04 +01:00
Fabien Castan
645d239333 [nodes] CameraInit: minor variable rename 2019-09-14 16:05:36 +02:00
Yann Lanthony
c6a3f0d587 [nodes] CameraInit.buildInstrincs: copy node outside graph if necessary
Instead of assuming that the CameraInit instance does not belong to a graph, handle this by making a temporary copy of it to work with.
2019-01-29 16:04:39 +01:00
Fabien Castan
6823695146
Merge pull request #369 from alicevision/dev_imageGallery_intrinsics
Image gallery improvements + intrinsics display
2019-01-29 16:02:56 +01:00
Yann Lanthony
0c9c2b2424
Merge pull request #329 from alicevision/devSfmIntrinsicsInput
[CLI] Add possibility to run pipeline from a .sfm file
2019-01-28 10:54:37 +01:00
Yann Lanthony
7db38abdf0 [nodes][av] CameraInit: add initializationMode and groupCameraFallback
* --allowIncompleteOutput option has been removed
* clean up commented lines
2019-01-21 10:55:17 +01:00
Simone Gasparini
3291c3b983
[nodes] forgot to remove print debug 2019-01-18 13:52:51 +01:00
Simone Gasparini
c0eb556eea
refactoring: function readSfMData() to read sfm files 2019-01-14 18:24:49 +01:00
Yann Lanthony
ed14294a29 [nodes][aliceVision] remove range sliders where unnecessary 2019-01-04 17:30:38 +01:00
Fabien Castan
877a852296
[node] CameraInit: improve "locked" param description 2018-12-10 12:08:45 +01:00
Grégoire De Lillo
98dec1ffd7 [node] CameraInit add per intrinsic param locked 2018-12-07 11:28:17 +01:00
Fabien Castan
6a138e492a [nodes] CameraInit: use json to load the metadata string 2018-08-05 20:44:02 +02:00
Fabien Castan
86fa806f65 [nodes] CameraInit bug fix: export view's metadata field
If we don't export it, we loose metadata when we add new images to a previous scene.
2018-08-05 20:44:02 +02:00
Grégoire De Lillo
5c4f10a2d1 [nodes] CameraInit fix: convert empty string distortionParams 2018-07-26 17:18:30 +02:00
Yann Lanthony
6014c701e4 [nodes] CameraInit: fix uid list on 'path' sub-attribute
only impacts uid 0
2018-07-19 13:50:45 +02:00
Yann Lanthony
67ac4bf2ca [core] split uids computation + cache override in updateInternals
* add _computeUids internal method + store computed uids in a dedicated dict
* cache override:
  * add optional cacheDir parameter on updateInternal method to override graph cache directory
  * _buildCmdVars always update member variable '_cmdVars' 
  * CameraInit: ensure node does not belong to a graph and use updateInternals with temp cache directory
2018-07-19 13:50:45 +02:00
Yann Lanthony
2a410d07ea [nodes][aliceVision] add initial version on nodes 2018-07-19 13:50:45 +02:00
Yann Lanthony
346277629a [nodes] use 'desc.Node.internalFolder' in outputs values
* avoid duplicating the same string everywhere
* don't override 'internalFolder' with the same value default value in subclasses
2018-07-19 13:50:45 +02:00
Yann Lanthony
6d1cf59fb1 [nodes] CameraInit: fix broken py3 compatibility + simplify json IO
* read: str.decode not available in py3; use io.open (available in py2/3) to specify encoding + errors handling
* write: direclty use json.dump to write viewpoints file
2018-07-06 10:43:39 +02:00
Fabien Castan
6e815c5d19
Merge pull request #135 from alicevision/dev_sfmOptions
Add support for AliceVision dev_sfmOptions branch
2018-07-02 16:15:34 +02:00
Yann Lanthony
e3246cc229 [cameraInit] improve error reporting when build intrinsics fails
* immediately raise if subprocess returns with an error code (avoid misleading error trying to open non-existing '.sfm' file)
* include error code and command line in the exception's message in such case
* avoid duplicate log message
2018-06-26 12:50:14 +02:00
Grégoire De Lillo
e27a2145b7 [nodes] Formatting and small fixes 2018-06-21 16:34:57 +02:00
Grégoire De Lillo
9ce6588b16 [nodes] CameraInit decode Json in UTF8 2018-06-21 16:34:57 +02:00
Yann Lanthony
001df5ee86 [nodes] formatting: fix tab instead of spaces 2018-03-06 15:34:41 +01:00
Gregoire De Lillo
00193addb1 [nodes] cameraInit: add defaultFieldOfView option 2018-02-06 17:23:22 +01:00
Gregoire De Lillo
4ca1e9387e [nodes] CameraInit : Add hidden flags allowSingleView and allowIncompleteOutput 2018-01-25 17:06:23 +01:00
Fabien Castan
9e144a52b6 [nodes] CameraInit: rebuild cmdVars at the end 2018-01-08 21:50:52 +01:00
Fabien Castan
7629236731 [nodes] CameraInit: fix quotes 2018-01-08 21:50:14 +01:00
Gregoire De Lillo
09904f1a33 [nodes] CameraInit: fix when metadata param is empty 2018-01-05 18:52:01 +01:00
Fabien Castan
8e1452d5bc [core] add quotes on strings
to deal with space characters on command line
2018-01-05 16:59:31 +01:00
Fabien Castan
74fac6143e [nodes] cameraInit: principal point is float 2017-12-20 16:14:56 +01:00
Yann Lanthony
8b58cd259b [nodes] CameraInit: store image metadata in Viewpoint
* store image metadata in StringParam 'metadata' on Viewpoints
* filter it out from viewpoints.sfm file (not needed)
2017-12-14 19:20:46 +01:00
Yann Lanthony
2f63d5b010 [nodes] CameraInit: change viewpoints file extension to .sfm
+ remove old method
2017-11-27 13:55:01 +01:00
Yann Lanthony
e8c579c942 [core] parallelization: introduce the notion of node 'size'
* node size is an estimation of the number of element to process on a given node, that may be used for parallelization.
* replace the explicit reference to an attribute on a node (Parallelization.inputListParamName)
* size can be:
  * dynamic: depends on the size of the node connected to a specific Attribute
  * static
2017-11-17 18:46:21 +01:00
Yann Lanthony
955609811d [nodes] CameraInit: fix typo 2017-11-14 10:12:03 +01:00
Yann Lanthony
2a029834db [nodes] Cleanup CameraInit
* remove non user pertinent parameters
* revamp old updateInternals into buildIntrinsics method:
    * works with node's current values + optional new images 
    * does not update the graph, making it thread safe and does not break undo/redo when used from UI
     * returns updated intrinsics and views instead
2017-11-13 20:28:00 +01:00
Yann Lanthony
bf747f69d6 Merge remote-tracking branch 'origin/develop' into dev_memoryManagement 2017-11-10 11:43:20 +01:00
Fabien Castan
cb29e02c0a [nodes] CameraInit: update to support views and intrinsics update 2017-11-10 11:37:01 +01:00
Yann Lanthony
2b73e0d80c [nodes] CameraInit: remove extra outputSfM + fix sfmData for empty filepaths 2017-11-08 18:43:27 +01:00
Fabien Castan
1e4f8f8a61 Add chunk notion for parallelization and implement specific updateInternals in CameraInit node
* Add chunk notion for parallelization
* Allows Node desc to implement custom updateInternals
* CameraInit node implement a specific updateInternals to update the
input image list
* FeatureExtraction, FeatureMatching, DepthMap, DepthMapFilter:
implement parallelization
2017-11-07 15:47:14 +01:00
Yann Lanthony
16e8037fd7 [core] change Attributes declaration on Node description
Inputs and outputs Attributes are now declared in two separate lists
* no more isOutput field on Attribute description
* guarantee attributes order (was not the case in Python2 with class attributes)
* Attribute's name is now part of its description

Note: for now, input and output Attributes are still stored in a single model inside a Graph.
2017-10-31 19:47:32 +01:00
Fabien Castan
b7175e219f [tests] test multiview pipeline and List/GroupAttributes set/get 2017-10-31 12:08:58 +01:00
Yann Lanthony
f8d9251c61 [aliceVision] Add Viewpoint parameter on CameraInit 2017-10-30 17:04:37 +01:00
Fabien Castan
0bdad5a588 [nodes] create default values from os.environ directly in nodes 2017-10-26 16:10:14 +02:00
Fabien Castan
6c8a2d06a1 [node] CameraInit: clean param description 2017-10-26 12:25:51 +02:00
Fabien Castan
d42c44af07 [nodes] verbose param should not invalidate 2017-10-19 12:27:30 +02:00
Fabien Castan
287c0f13ce [core] split Param into specific types and update nodes accordingly 2017-10-16 12:23:59 +02:00
Fabien Castan
aacdf32915 Move nodes into subfolders 2017-10-16 12:23:58 +02:00
Renamed from meshroom/nodes/CameraInit.py (Browse further)