Commit graph

91 commits

Author SHA1 Message Date
Fabien Castan
443237e265 [nodes] CameraInit,ImageProcessing: enable white balance by default 2022-12-13 15:30:46 +01:00
demoulinv
c0fc6c76a1 [nodes] CameraInit,ImageProcessing: Add parameters related to color profiles management 2022-12-13 14:36:17 +01:00
fabien servant
ae0ca71c1c [nodes] replace CommandLineNode with AVCommandLineNode for alicevision nodes 2022-12-06 15:07:01 +01:00
Candice Bentéjac
189cb6be5b [nodes] Use raw strings for parameters that contain regular expressions
Regular expressions in regular strings generate deprecation warnings
with Python 3 ("invalid escape sequence \x"). To fix these warnings,
the regex must be contained within a raw string. For nodes that have
parameters whose description and/or value contain regex, the strings
are transformed into raw strings. In the case of descriptions, which are
generally written across several lines, regular strings are concatenated
with regular strings to preserve line returns (with "\n", which becomes
uneffective in raw strings).
2022-12-05 17:16:22 +01:00
Candice Bentéjac
8bef398bed Remove workarounds and backports for Python 2 support
In particular:
- In common/, remove the backport of weakref.WeakMethod
- In docs/ and ui/, use the standard FileNotFoundError class
- Use built-in open() instead of io.open(), and stop importing io
- In core/stats.py, use the standard implementation of xml.etree instead
of the C one
2022-12-05 17:16:21 +01:00
Candice Bentéjac
e7290313bf [nodes] Align FloatParams' and IntParams' ranges with their params' type 2022-09-28 10:41:39 +02:00
Candice Bentéjac
83f1876e2c [nodes] CameraInit: set float default values for FloatParams
Fix the parameters with default values that do not correspond to
the parameters' types. For CameraInit, all the default values of
FloatParams that are set with integers are replaced with actual
float values.

These default values with an erroneous type would cause changes
in the CameraInit's UID when the intrinsics' default values were
written (with values of the correct type) and when they were
loaded (with values of the wrong type).
2022-09-26 17:48:57 +02:00
Fabien Castan
95bb93b4bf [nodes] CameraInit: upgrade node version
Change in uid should modify the node version and thus require a manual upgrade of the node when loading previous scenes.
2022-09-15 17:29:15 +02:00
Fabien Castan
032ac712fd [nodes] CameraInit: all intrinsics parameters should invalidate 2022-09-15 17:29:15 +02:00
Candice Bentéjac
659c8a05ed Add abstract InitNode
InitNode is an abstract class which is meant to be inherited
by all the initialization nodes (such as CameraInit), included
those that might be created by the user.

InitNode contains methods that can be reimplemented by the
children classes if necessary.

This abstract class allows to keep on using scripts such as
meshroom_batch without having to modify them specifically or
being limited to using a CameraInit node.
2022-08-05 10:42:59 +02:00
Candice Bentéjac
7ec65d828c Do not evaluate variables of string parameters in the nodes' description
Set the value of the string parameters in the nodes' description as
the unevaluated variable instead of the evaluated variable. The
evaluation will be made later, when the nodes with such parameters
will be computed.
2022-07-12 11:22:57 +02:00
Fabien Castan
7083b01819 [nodes] CameraInit: pixelRatioLocked True by default 2022-04-11 17:01:38 +02:00
fabien servant
655dad9959 [camerainit] update parameters to use focal in mm 2022-03-25 11:07:52 +01:00
Fabien Castan
8beb821907 [nodes] CameraInit: use os.path.join 2021-09-13 10:17:40 +02:00
Fabien Castan
61308eb211 [nodes] CameraInit: Principal Point is now relative to the image center
The principal point is no more relative to the top-left corner of the image.
Linked to the AliceVision sfmData IO change in file version 1.2.1.
2021-08-19 09:50:15 +02:00
Fabien Castan
5ab6ed8e52 [core] Improve project files upgrade
- upgrade groups with changes in params
- new upgradeAttributeValues per node
2021-08-13 16:07:14 +02:00
Fabien Castan
14579f766d [nodes] CameraInit: fix version of aliceVision json file
The intrinsics contains pxFocalLength as 2 values (x,y) since 1.2
version.
2021-05-31 18:27:21 +02:00
Fabien Castan
f03cb7de54 [nodes] CameraInit: add camera models in description 2021-05-28 15:53:27 +02:00
Fabien Servant
03a47a9a45 [calibration] update cameras names 2021-05-28 15:53:26 +02:00
Fabien Servant
ba247e4e9c [node] add new camera model 2021-05-28 15:53:25 +02:00
Fabien Servant
d3dae57c30 [calibration] add some camera lenses models 2021-05-28 15:53:25 +02:00
Fabien
248b14eb62 [cameraInit] add support for non square pixels 2021-05-28 15:53:24 +02:00
Fabien Castan
7d4e9524ad Update nodes versions 2021-02-26 00:52:50 +01:00
ChemicalXandco
e18f815af9 [nodes] add node categories 2021-02-14 17:03:42 +00:00
Fabien Castan
1102ce84e0 Merge branch 'develop' of github.com:alicevision/meshroom into dev/nodesAndTaskManager
Conflicts:
	meshroom/core/graph.py
	meshroom/ui/qml/main.qml
2020-12-01 20:02:43 +01:00
Fabien
d62eca1648 [camerainit] add a boolean for white balance use 2020-11-23 08:05:40 +01:00
Fabien Castan
bab908d2eb Merge branch 'develop' into dev/nodesAndTaskManager 2020-07-30 10:56:19 +02:00
Fabien Castan
7b1a2aac0b [nodes] CameraInit: no more params invalidation
Params are only used on drag&drop and do not invalidate the node
computation.
Only Viewpoints and Intrinsics are now used in the invalidation.
2020-07-29 18:33:39 +02:00
Julien-Haudegond
4e20286ac0 [nodes] increment nodes version 2020-07-29 14:39:38 +02:00
Julien-Haudegond
d1756ca650 [nodes] update several nodes with enabled parameter 2020-07-29 11:38:13 +02:00
Fabien Castan
91f53341bc warning fixes 2020-07-16 11:04:43 +02:00
Fabien Castan
224abce62f [nodes] CameraInit: add some debug log 2020-07-02 11:57:50 +02:00
Fabien Castan
44d6b45c18 Merge branch 'develop' into dev/panoramaFisheye 2020-07-01 01:15:27 +02:00
Fabien Castan
253d9d569d [nodes] CameraInit: view regex is an advanced param 2020-06-30 22:54:56 +02:00
Enguerrand DE SMET
162a6804ab [nodes] camerainit: viewId from filename 2020-06-30 20:41:13 +02:00
Enguerrand DE SMET
95c8cf1ff4 [nodes] cameraInit: allowed intrinsics option 2020-06-30 17:41:16 +02:00
Fabien Castan
43d7fc1c1d [nodes] CameraInit: no special characters in descriptions 2020-03-26 19:25:51 +01:00
Fabien Castan
64a4c9426a [nodes] add some nodes documentation 2020-03-26 11:20:44 +01:00
fabienservant
ff34102190 Add sensor size to camera init 2020-03-10 17:29:31 +01:00
fabienservant
1b8aea7db3 add camera type choice for equidistant 2020-03-10 17:03:29 +01:00
Fabien Castan
19d2f90554 [ui] ImageGallery: allow to visualize the list of HDR images created by LDRToHDR
Conflicts:
	meshroom/ui/reconstruction.py
2020-03-10 12:33:36 +01:00
Yann Lanthony
991aca989b Merge develop into dev/nodesAndTaskManager 2020-01-24 14:54:08 +01:00
Yann Lanthony
ac149e1e51 [nodes][aliceVision] use user-friendly atribute labels 2020-01-24 12:00:13 +01:00
Fabien Castan
69a1f157ac [nodes] CameraInit: remove subprocess wait (communicate is enough) 2019-12-16 20:10:04 +01:00
Fabien Castan
645d239333 [nodes] CameraInit: minor variable rename 2019-09-14 16:05:36 +02:00
Yann Lanthony
c6a3f0d587 [nodes] CameraInit.buildInstrincs: copy node outside graph if necessary
Instead of assuming that the CameraInit instance does not belong to a graph, handle this by making a temporary copy of it to work with.
2019-01-29 16:04:39 +01:00
Fabien Castan
6823695146
Merge pull request #369 from alicevision/dev_imageGallery_intrinsics
Image gallery improvements + intrinsics display
2019-01-29 16:02:56 +01:00
Yann Lanthony
0c9c2b2424
Merge pull request #329 from alicevision/devSfmIntrinsicsInput
[CLI] Add possibility to run pipeline from a .sfm file
2019-01-28 10:54:37 +01:00
Yann Lanthony
7db38abdf0 [nodes][av] CameraInit: add initializationMode and groupCameraFallback
* --allowIncompleteOutput option has been removed
* clean up commented lines
2019-01-21 10:55:17 +01:00
Simone Gasparini
3291c3b983
[nodes] forgot to remove print debug 2019-01-18 13:52:51 +01:00