3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-31 23:38:48 +02:00
Code Issues Projects Releases Packages Wiki Activity

[GraphEditor] Remove enabling/disabling pins depending on edge's visibility

Browse source 
When edges could exist while being invisible in the graph, pins needed
to be enabled/disabled manually according to the visibility of the edge.
This was especially important when closing the application and removing
all the (hidden) edges as the pins needed to be properly destryed as well.

Edges are not hidden anymore, and any attribute that should be hidden
but is in fact connected remains visible as long as the connection exists.
This commit is contained in:
Candice Bentéjac 2024-12-13 17:05:30 +01:00
parent 4280295e90
commit f521bfa663
2 changed files with 0 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
meshroom/ui/qml/GraphEditor/GraphEditor.qml
View file

@ -511,18 +511,6 @@ Item {
}
}
}
Component.onDestruction: {
// Handles the case where the edge is destroyed while hidden because it is replaced: the pins should be re-enabled
if (!_window.isClosing) {
// When the window is closing, the QML context becomes invalid, which causes function calls to result in errors
if (src && src !== undefined)
src.updatePin(true, true) // isSrc = true, isVisible = true
if (dst && dst !== undefined)
dst.updatePin(false, true) // isSrc = false, isVisible = true
}
}
}
}