3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-06-12 15:52:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

[tests] Remove invalid= when the implicit argument is enough

Browse source
This commit is contained in:
Candice Bentéjac 2024-09-06 17:37:58 +02:00
parent 41a1b47c43
commit ec0721d381
5 changed files with 21 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/nodes/test/appendFiles.py
View file

@ -10,28 +10,24 @@ class AppendFiles(desc.CommandLineNode):
label='Input File', label='Input File',
description='''''', description='''''',
value='', value='',
invalidate=True,
), ),
desc.File( desc.File(
name='input2', name='input2',
label='Input File 2', label='Input File 2',
description='''''', description='''''',
value='', value='',
invalidate=True,
), ),
desc.File( desc.File(
name='input3', name='input3',
label='Input File 3', label='Input File 3',
description='''''', description='''''',
value='', value='',
invalidate=True,
), ),
desc.File( desc.File(
name='input4', name='input4',
label='Input File 4', label='Input File 4',
description='''''', description='''''',
value='', value='',
invalidate=True,
), ),
] ]
@ -41,7 +37,6 @@ class AppendFiles(desc.CommandLineNode):
label='Output', label='Output',
description='''''', description='''''',
value=desc.Node.internalFolder + 'appendText.txt', value=desc.Node.internalFolder + 'appendText.txt',
invalidate=False,
) )
] ]

3
tests/nodes/test/appendText.py
View file

@ -10,14 +10,12 @@ class AppendText(desc.CommandLineNode):
label='Input File', label='Input File',
description='''''', description='''''',
value='', value='',
invalidate=True,
), ),
desc.File( desc.File(
name='inputText', name='inputText',
label='Input Text', label='Input Text',
description='''''', description='''''',
value='', value='',
invalidate=True,
) )
] ]
@ -27,6 +25,5 @@ class AppendText(desc.CommandLineNode):
label='Output', label='Output',
description='''''', description='''''',
value=desc.Node.internalFolder + 'appendText.txt', value=desc.Node.internalFolder + 'appendText.txt',
invalidate=False,
), ),
] ]

2
tests/nodes/test/ls.py
View file

@ -9,7 +9,6 @@ class Ls(desc.CommandLineNode):
label='Input', label='Input',
description='''''', description='''''',
value='', value='',
invalidate=True,
) )
] ]
@ -19,6 +18,5 @@ class Ls(desc.CommandLineNode):
label='Output', label='Output',
description='''''', description='''''',
value=desc.Node.internalFolder + 'ls.txt', value=desc.Node.internalFolder + 'ls.txt',
invalidate=False,
) )
] ]

38
tests/test_compatibility.py
View file

@ -14,17 +14,17 @@ from meshroom.core.node import CompatibilityNode, CompatibilityIssue, Node
SampleGroupV1 = [ SampleGroupV1 = [
desc.IntParam(name="a", label="a", description="", value=0, invalidate=True, range=None), desc.IntParam(name="a", label="a", description="", value=0, range=None),
desc.ListAttribute( desc.ListAttribute(
name="b", name="b",
elementDesc=desc.FloatParam(name="p", label="", description="", value=0.0, invalidate=True, range=None), elementDesc=desc.FloatParam(name="p", label="", description="", value=0.0, range=None),
label="b", label="b",
description="", description="",
) )
] ]
SampleGroupV2 = [ SampleGroupV2 = [
desc.IntParam(name="a", label="a", description="", value=0, invalidate=True, range=None), desc.IntParam(name="a", label="a", description="", value=0, range=None),
desc.ListAttribute( desc.ListAttribute(
name="b", name="b",
elementDesc=desc.GroupAttribute(name="p", label="", description="", groupDesc=SampleGroupV1), elementDesc=desc.GroupAttribute(name="p", label="", description="", groupDesc=SampleGroupV1),
@ -35,8 +35,8 @@ SampleGroupV2 = [
# SampleGroupV3 is SampleGroupV2 with one more int parameter # SampleGroupV3 is SampleGroupV2 with one more int parameter
SampleGroupV3 = [ SampleGroupV3 = [
desc.IntParam(name="a", label="a", description="", value=0, invalidate=True, range=None), desc.IntParam(name="a", label="a", description="", value=0, range=None),
desc.IntParam(name="notInSampleGroupV2", label="notInSampleGroupV2", description="", value=0, invalidate=True, range=None), desc.IntParam(name="notInSampleGroupV2", label="notInSampleGroupV2", description="", value=0, range=None),
desc.ListAttribute( desc.ListAttribute(
name="b", name="b",
elementDesc=desc.GroupAttribute(name="p", label="", description="", groupDesc=SampleGroupV1), elementDesc=desc.GroupAttribute(name="p", label="", description="", groupDesc=SampleGroupV1),
@ -49,11 +49,11 @@ SampleGroupV3 = [
class SampleNodeV1(desc.Node): class SampleNodeV1(desc.Node):
""" Version 1 Sample Node """ """ Version 1 Sample Node """
inputs = [ inputs = [
desc.File(name='input', label='Input', description='', value='', invalidate=True,), desc.File(name='input', label='Input', description='', value='',),
desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False) # No impact on UID desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False) # No impact on UID
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -62,11 +62,11 @@ class SampleNodeV2(desc.Node):
* 'input' has been renamed to 'in' * 'input' has been renamed to 'in'
""" """
inputs = [ inputs = [
desc.File(name='in', label='Input', description='', value='', invalidate=True,), desc.File(name='in', label='Input', description='', value='',),
desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False), # No impact on UID desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False), # No impact on UID
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -76,10 +76,10 @@ class SampleNodeV3(desc.Node):
* 'paramA' has been removed' * 'paramA' has been removed'
""" """
inputs = [ inputs = [
desc.File(name='in', label='Input', description='', value='', invalidate=True, ), desc.File(name='in', label='Input', description='', value='',),
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -89,14 +89,14 @@ class SampleNodeV4(desc.Node):
* 'paramA' has been added * 'paramA' has been added
""" """
inputs = [ inputs = [
desc.File(name='in', label='Input', description='', value='', invalidate=True, ), desc.File(name='in', label='Input', description='', value='',),
desc.ListAttribute(name='paramA', label='ParamA', desc.ListAttribute(name='paramA', label='ParamA',
elementDesc=desc.GroupAttribute( elementDesc=desc.GroupAttribute(
groupDesc=SampleGroupV1, name='gA', label='gA', description=''), groupDesc=SampleGroupV1, name='gA', label='gA', description=''),
description='') description='')
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -106,14 +106,14 @@ class SampleNodeV5(desc.Node):
* 'paramA' elementDesc has changed from SampleGroupV1 to SampleGroupV2 * 'paramA' elementDesc has changed from SampleGroupV1 to SampleGroupV2
""" """
inputs = [ inputs = [
desc.File(name='in', label='Input', description='', value='', invalidate=True), desc.File(name='in', label='Input', description='', value=''),
desc.ListAttribute(name='paramA', label='ParamA', desc.ListAttribute(name='paramA', label='ParamA',
elementDesc=desc.GroupAttribute( elementDesc=desc.GroupAttribute(
groupDesc=SampleGroupV2, name='gA', label='gA', description=''), groupDesc=SampleGroupV2, name='gA', label='gA', description=''),
description='') description='')
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -123,14 +123,14 @@ class SampleNodeV6(desc.Node):
* 'paramA' elementDesc has changed from SampleGroupV2 to SampleGroupV3 * 'paramA' elementDesc has changed from SampleGroupV2 to SampleGroupV3
""" """
inputs = [ inputs = [
desc.File(name='in', label='Input', description='', value='', invalidate=True), desc.File(name='in', label='Input', description='', value=''),
desc.ListAttribute(name='paramA', label='ParamA', desc.ListAttribute(name='paramA', label='ParamA',
elementDesc=desc.GroupAttribute( elementDesc=desc.GroupAttribute(
groupDesc=SampleGroupV3, name='gA', label='gA', description=''), groupDesc=SampleGroupV3, name='gA', label='gA', description=''),
description='') description='')
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -140,7 +140,7 @@ class SampleInputNodeV1(desc.InputNode):
desc.StringParam(name='path', label='path', description='', value='', invalidate=False) # No impact on UID desc.StringParam(name='path', label='path', description='', value='', invalidate=False) # No impact on UID
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]
@ -152,7 +152,7 @@ class SampleInputNodeV2(desc.InputNode):
desc.StringParam(name='in', label='path', description='', value='', invalidate=False) # No impact on UID desc.StringParam(name='in', label='path', description='', value='', invalidate=False) # No impact on UID
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]

4
tests/test_invalidation.py
View file

@ -7,11 +7,11 @@ from meshroom.core import desc, registerNodeType
class SampleNode(desc.Node): class SampleNode(desc.Node):
""" Sample Node for unit testing """ """ Sample Node for unit testing """
inputs = [ inputs = [
desc.File(name='input', label='Input', description='', value='', invalidate=True,), desc.File(name='input', label='Input', description='', value='',),
desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False) # No impact on UID desc.StringParam(name='paramA', label='ParamA', description='', value='', invalidate=False) # No impact on UID
] ]
outputs = [ outputs = [
desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder, invalidate=False) desc.File(name='output', label='Output', description='', value=desc.Node.internalFolder)
] ]