From 81c6cd022cdd2396180b54aafa4457961581f6f1 Mon Sep 17 00:00:00 2001 From: demoulinv Date: Fri, 18 Aug 2023 09:23:01 +0200 Subject: [PATCH 1/2] [Node] LdrToHdrXXX : update exposure computation --- meshroom/nodes/aliceVision/LdrToHdrCalibration.py | 2 +- meshroom/nodes/aliceVision/LdrToHdrMerge.py | 2 +- meshroom/nodes/aliceVision/LdrToHdrSampling.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meshroom/nodes/aliceVision/LdrToHdrCalibration.py b/meshroom/nodes/aliceVision/LdrToHdrCalibration.py index 6655f817..8c9ec458 100644 --- a/meshroom/nodes/aliceVision/LdrToHdrCalibration.py +++ b/meshroom/nodes/aliceVision/LdrToHdrCalibration.py @@ -316,6 +316,6 @@ Calibrate LDR to HDR response curve from samples. isoToAperture = math.sqrt(iso / refIso) newFnumber = fnumber * isoToAperture - expIncrease = (newFnumber / lRefFnumber) * (newFnumber / lRefFnumber) + expIncrease = (lRefFnumber / newFnumber) * (lRefFnumber / newFnumber) return shutterSpeed * expIncrease diff --git a/meshroom/nodes/aliceVision/LdrToHdrMerge.py b/meshroom/nodes/aliceVision/LdrToHdrMerge.py index c6bb797e..aae38c7e 100644 --- a/meshroom/nodes/aliceVision/LdrToHdrMerge.py +++ b/meshroom/nodes/aliceVision/LdrToHdrMerge.py @@ -402,7 +402,7 @@ Merge LDR images into HDR images. isoToAperture = math.sqrt(iso / refIso) newFnumber = fnumber * isoToAperture - expIncrease = (newFnumber / lRefFnumber) * (newFnumber / lRefFnumber) + expIncrease = (lRefFnumber / newFnumber) * (lRefFnumber / newFnumber) return shutterSpeed * expIncrease diff --git a/meshroom/nodes/aliceVision/LdrToHdrSampling.py b/meshroom/nodes/aliceVision/LdrToHdrSampling.py index 7f0dccad..857a9700 100644 --- a/meshroom/nodes/aliceVision/LdrToHdrSampling.py +++ b/meshroom/nodes/aliceVision/LdrToHdrSampling.py @@ -344,6 +344,6 @@ Sample pixels from Low range images for HDR creation. isoToAperture = math.sqrt(iso / refIso) newFnumber = fnumber * isoToAperture - expIncrease = (newFnumber / lRefFnumber) * (newFnumber / lRefFnumber) + expIncrease = (lRefFnumber / newFnumber) * (lRefFnumber / newFnumber) return shutterSpeed * expIncrease From dfa2c6b80df6fccb0b83664456221d04bef9e18d Mon Sep 17 00:00:00 2001 From: demoulinv Date: Fri, 18 Aug 2023 09:29:34 +0200 Subject: [PATCH 2/2] [Nodes] Texturing : Change default value for CorrectEV option from False to True enabling automatic exposure correction for texture creation. --- meshroom/nodes/aliceVision/Texturing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meshroom/nodes/aliceVision/Texturing.py b/meshroom/nodes/aliceVision/Texturing.py index 631ab8f4..392e1c20 100644 --- a/meshroom/nodes/aliceVision/Texturing.py +++ b/meshroom/nodes/aliceVision/Texturing.py @@ -278,7 +278,7 @@ Many cameras are contributing to the low frequencies and only the best ones cont name="correctEV", label="Correct Exposure", description="Uniformize images exposure values.", - value=False, + value=True, uid=[0], ), desc.BoolParam(