3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-08-06 10:18:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

[cameraInit] improve error reporting when build intrinsics fails

Browse source 
* immediately raise if subprocess returns with an error code (avoid misleading error trying to open non-existing '.sfm' file)
* include error code and command line in the exception's message in such case
* avoid duplicate log message
This commit is contained in:
Yann Lanthony 2018-06-26 12:47:44 +02:00
parent d5d8fa77dc
commit e3246cc229
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
meshroom/nodes/aliceVision/CameraInit.py
View file

@ -129,7 +129,9 @@ class CameraInit(desc.CommandLineNode):
stdout, stderr = subprocess.communicate() stdout, stderr = subprocess.communicate()
subprocess.wait() subprocess.wait()
if subprocess.returncode != 0: if subprocess.returncode != 0:
logging.warning('CameraInit: Error on buildIntrinsics of node "{}".'.format(node.name)) raise RuntimeError('CameraInit failed with error code {}. Command was: "{}"'.format(
subprocess.returncode, cmd)
)
# Reload result of aliceVision_cameraInit # Reload result of aliceVision_cameraInit
cameraInitSfM = node.output.value cameraInitSfM = node.output.value
@ -152,7 +154,6 @@ class CameraInit(desc.CommandLineNode):
return views, intrinsics return views, intrinsics
except Exception: except Exception:
logging.warning('CameraInit: Error on buildIntrinsics of node "{}".'.format(node.name))
raise raise
finally: finally:
node._cmdVars = origCmdVars node._cmdVars = origCmdVars