From dcbee52611a17ecafcfa4bb7184f1bb9ea965eca Mon Sep 17 00:00:00 2001 From: ChemicalXandco Date: Mon, 16 Mar 2020 17:38:54 +0000 Subject: [PATCH] make comment clearer --- meshroom/nodes/aliceVision/SketchfabUpload.py | 1 + setup.py | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/meshroom/nodes/aliceVision/SketchfabUpload.py b/meshroom/nodes/aliceVision/SketchfabUpload.py index 311ace6f..27bea2fb 100644 --- a/meshroom/nodes/aliceVision/SketchfabUpload.py +++ b/meshroom/nodes/aliceVision/SketchfabUpload.py @@ -219,6 +219,7 @@ class SketchfabUpload(desc.Node): try: self._stopped = False chunk.logManager.start(chunk.node.verboseLevel.value) + uploadFile = '' if not chunk.node.inputFiles: chunk.logger.warning('Nothing to upload') diff --git a/setup.py b/setup.py index 2c423189..c14ed6b2 100644 --- a/setup.py +++ b/setup.py @@ -41,8 +41,9 @@ class PlatformExecutable(Executable): build_exe_options = { # include dynamically loaded plugins "packages": ["meshroom.nodes", "meshroom.submitters"], - # cx_Freeze does not copy idnadata by default, so it needs to be added here - "includes": ["idna.idnadata"], + "includes": [ + "idna.idnadata", # Dependency needed by SketchfabUpload node, but not detected by cx_Freeze + ], "include_files": ["CHANGES.md", "COPYING.md", "LICENSE-MPL2.md", "README.md"] }