3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-06-01 02:12:04 +02:00
Code Issues Projects Releases Packages Wiki Activity

[nodes] HDR Fusion: Detect new exposure groups when inputs' paths change

Browse source 
In addition to comparing the exposure levels of the sorted input images
to determine whether a new exposure group must be created, this commit
adds a detection based on the path of the image: if the directory
containing the current image is not the same as the one of the previous
image, then we assume the dataset is different, and there is no point
in comparing the current image's exposure level with the previous one's.

Instead, we directly create a new exposure group.

In cases where images from different datasets have very similar
exposure levels, this prevents having outliers identified as being part
of the current exposure group.
This commit is contained in:
Candice Bentéjac 2023-07-17 16:45:21 +02:00
parent 6a0583d8e5
commit 9c35919c35
3 changed files with 51 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

21
meshroom/nodes/aliceVision/LdrToHdrSampling.py
View file

@ -1,6 +1,7 @@
__version__ = "4.0"
import json
import os
from collections import Counter
from meshroom.core import desc
@ -234,20 +235,32 @@ Sample pixels from Low range images for HDR creation.
prevFnumber = 0.0
prevShutterSpeed = 0.0
prevIso = 0.0
prevPath = None # Stores the dirname of the previous parsed image
newGroup = False # True if a new exposure group needs to be created (useful when there are several datasets)
for path, exp in inputs:
# A new group is created if the current image's exposure level is larger than the previous image's, or if there
# were any changes in the ISO or aperture value.
# If the dirname of the previous image and the dirname of the current image do not match, this means that the
# dataset that is being parsed has changed. A new group needs to be created but will fail to be detected in the
# next "if" statement if the new dataset's exposure levels are different. Setting "newGroup" to True prevents this
# from happening.
if prevPath is not None and prevPath != os.path.dirname(path):
newGroup = True
# A new group is created if the current image's exposure level is larger than the previous image's, if there
# were any changes in the ISO or aperture value, or if a new dataset has been detected with the path.
# Since the input images are ordered, the shutter speed should always be decreasing, so a shutter speed larger
# than the previous one indicates the start of a new exposure group.
fnumber, shutterSpeed, iso = exp
if exposures:
prevFnumber, prevShutterSpeed, prevIso = exposures[-1]
if exposures and len(exposures) > 1 and (fnumber != prevFnumber or shutterSpeed > prevShutterSpeed or iso != prevIso):
if exposures and len(exposures) > 1 and (fnumber != prevFnumber or shutterSpeed > prevShutterSpeed or iso != prevIso) or newGroup:
exposureGroups.append(exposures)
exposures = [exp]
else:
exposures.append(exp)
prevPath = os.path.dirname(path)
newGroup = False
exposureGroups.append(exposures)
exposures = None
@ -270,7 +283,7 @@ Sample pixels from Low range images for HDR creation.
bestBracketSize = bestTuple[0]
bestCount = bestTuple[1]
total = bestBracketSize * bestCount
if len(inputs) - total < 2:
if total >= len(inputs) - 2:
node.nbBrackets.value = bestBracketSize
else:
node.nbBrackets.value = 0