3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-31 07:18:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

[ui] Fix "canSubmit" which relied on erroneous conditions

Browse source 
Remove the "canStartComputation" condition which was not used anywhere
else and was not up-to-date: since it needed more than one image and no
ongoing computations to be "True", attempting to submit several branches
of a graph would always cause it to be "False", which in turn led the
"canSubmit" condition to be "False" (causing the pop-up requesting to
save the file to appear), even though the submission should have been
possible.

The submission should be possible whenever submitters are available and
the project file has been saved.
This commit is contained in:
Candice Bentéjac 2023-03-20 16:18:48 +01:00
parent ba0541c791
commit 9570437b7f
1 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
meshroom/ui/qml/main.qml
View file

@ -184,17 +184,9 @@ ApplicationWindow {
property bool warnIfUnsaved: true
// evaluate if global reconstruction computation can be started
property bool canStartComputation: _reconstruction ?
_reconstruction.viewpoints.count >= 2 // at least 2 images
&& !_reconstruction.computing // computation is not started
&& _reconstruction.graph.canComputeLeaves : // graph has no uncomputable nodes
false
// evaluate if graph computation can be submitted externally
property bool canSubmit: _reconstruction ?
_reconstruction.canSubmit // current setup allows to compute externally
&& canStartComputation // can be computed
&& _reconstruction.graph.filepath : // graph is saved on disk
false