3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-15 07:45:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

[core] plugins: Handle corner cases when reloading nodes

Browse source
This commit is contained in:
Candice Bentéjac 2025-06-05 16:04:55 +02:00
parent a19c306cf3
commit 91e753c114
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
meshroom/core/plugins.py
View file

@ -205,23 +205,32 @@ class NodePlugin(BaseObject):
def reload(self): def reload(self):
""" Reload the node plugin and update its status accordingly. """ """ Reload the node plugin and update its status accordingly. """
if self._timestamp == os.path.getmtime(self.path): timestamp = 0.0
try:
timestamp = os.path.getmtime(self.path)
except FileNotFoundError:
self.status = NodePluginStatus.ERROR
logging.error(f"[Reload] {self.nodeDescriptor.__name__}: The path at {self.path} was not "
"not found.")
return
if self._timestamp == timestamp:
logging.info(f"[Reload] {self.nodeDescriptor.__name__}: Not reloading. The node description " logging.info(f"[Reload] {self.nodeDescriptor.__name__}: Not reloading. The node description "
f"at {self.path} has not been modified since the last load.") f"at {self.path} has not been modified since the last load.")
return return
updated = importlib.reload(sys.modules.get(self.nodeDescriptor.__module__)) updated = importlib.reload(sys.modules.get(self.nodeDescriptor.__module__))
descriptor = getattr(updated, self.nodeDescriptor.__name__) descriptor = getattr(updated, self.nodeDescriptor.__name__)
self._timestamp = os.path.getmtime(self.path)
if not descriptor: if not descriptor:
self.status = NodePluginStatus.ERROR self.status = NodePluginStatus.ERROR
logging.error(f"[Reload] {self.nodeDescriptor.__name__}: The node description at {self.path} " logging.error(f"[Reload] {self.nodeDescriptor.__name__}: The node description at {self.path} "
"was not found.") "was not found.")
return return
self.nodeDescriptor = descriptor self.nodeDescriptor = descriptor
self.errors = validateNodeDesc(descriptor) self.errors = validateNodeDesc(descriptor)
self._timestamp = timestamp
if self.errors: if self.errors:
self.status = NodePluginStatus.DESC_ERROR self.status = NodePluginStatus.DESC_ERROR