3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-31 23:38:48 +02:00
Code Issues Projects Releases Packages Wiki Activity

[core] Raise compatibility issue if nodes miss invalidating internal attributes

Browse source
This commit is contained in:
Candice Bentéjac 2022-11-18 18:01:48 +01:00
parent b470078667
commit 7688b94ce5
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
meshroom/core/node.py
View file

@ -1597,6 +1597,19 @@ def nodeFactory(nodeDict, name=None, template=False):
sorted([attr.name for attr in nodeDesc.outputs]) != sorted(outputs.keys())):
compatibilityIssue = CompatibilityIssue.DescriptionConflict
# check whether there are any internal attributes that are invalidating in the node description: if there
# are, then check that these internal attributes are part of nodeDict; if they are not, a compatibility
# issue must be raised to warn the user, as this will automatically change the node's UID
if not template:
invalidatingIntInputs = []
for attr in nodeDesc.internalInputs:
if attr.uid == [0]:
invalidatingIntInputs.append(attr.name)
for attr in invalidatingIntInputs:
if attr not in internalInputs.keys():
compatibilityIssue = CompatibilityIssue.DescriptionConflict
break
# verify that all inputs match their descriptions
for attrName, value in inputs.items():
if not CompatibilityNode.attributeDescFromName(nodeDesc.inputs, attrName, value):