From 73332694fa4d83bc0fadd2ccfffc8e02d8544193 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Candice=20Bent=C3=A9jac?= Date: Wed, 24 May 2023 11:17:02 +0200 Subject: [PATCH] [nodes] Improve labels and descriptions for distortion calibration nodes --- meshroom/nodes/aliceVision/ApplyCalibration.py | 4 ++-- meshroom/nodes/aliceVision/CameraInit.py | 6 +++--- meshroom/nodes/aliceVision/DistortionCalibration.py | 10 +++++----- meshroom/nodes/aliceVision/ExportDistortion.py | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/meshroom/nodes/aliceVision/ApplyCalibration.py b/meshroom/nodes/aliceVision/ApplyCalibration.py index e3f0bd30..43c88b4e 100644 --- a/meshroom/nodes/aliceVision/ApplyCalibration.py +++ b/meshroom/nodes/aliceVision/ApplyCalibration.py @@ -31,8 +31,8 @@ Overwrite intrinsics with a calibrated intrinsic. outputs = [ desc.File( name='output', - label='SfMData File.', - description='Path to the output sfmData file.', + label='SfMData File', + description='Path to the output SfMData file.', value=desc.Node.internalFolder + 'sfmData.sfm', uid=[], ), diff --git a/meshroom/nodes/aliceVision/CameraInit.py b/meshroom/nodes/aliceVision/CameraInit.py index 1090336e..10cf4d6a 100644 --- a/meshroom/nodes/aliceVision/CameraInit.py +++ b/meshroom/nodes/aliceVision/CameraInit.py @@ -89,12 +89,12 @@ Intrinsic = [ name="distortionParams", elementDesc=desc.FloatParam(name="p", label="", description="", value=0.0, uid=[0], range=(-0.1, 0.1, 0.01)), label="Distortion Params", - description="Distortion Parameters", + description="Distortion parameters.", ), desc.GroupAttribute( name="undistortionOffset", label="Undistortion Offset", - description="Undistortion Offset", + description="Undistortion offset.", groupDesc=[ desc.FloatParam(name="x", label="x", description="", value=0.0, uid=[0], range=(0.0, 10000.0, 1.0)), desc.FloatParam(name="y", label="y", description="", value=0.0, uid=[0], range=(0.0, 10000.0, 1.0)), @@ -104,7 +104,7 @@ Intrinsic = [ name="undistortionParams", elementDesc=desc.FloatParam(name="p", label="", description="", value=0.0, uid=[0], range=(-0.1, 0.1, 0.01)), label="Undistortion Params", - description="Undistortion Parameters" + description="Undistortion parameters." ), desc.BoolParam(name='locked', label='Locked', description='If the camera has been calibrated, the internal camera parameters (intrinsics) can be locked. It should improve robustness and speedup the reconstruction.', diff --git a/meshroom/nodes/aliceVision/DistortionCalibration.py b/meshroom/nodes/aliceVision/DistortionCalibration.py index eb38efaa..9bbfaa79 100644 --- a/meshroom/nodes/aliceVision/DistortionCalibration.py +++ b/meshroom/nodes/aliceVision/DistortionCalibration.py @@ -15,14 +15,14 @@ Calibration of a camera/lens couple distortion using a full screen checkerboard. inputs = [ desc.File( name='input', - label='SfmData', - description='SfmData File.', + label='Input SfMData', + description='SfMData file.', value='', uid=[0], ), desc.File( name='checkerboards', - label='Checkerboards folder', + label='Checkerboards Folder', description='Folder containing checkerboard JSON files.', value='', uid=[0], @@ -41,8 +41,8 @@ Calibration of a camera/lens couple distortion using a full screen checkerboard. outputs = [ desc.File( name='output', - label='SfmData File', - description='Path to the output sfmData file.', + label='SfMData File', + description='Path to the output SfMData file.', value=desc.Node.internalFolder + 'sfmData.sfm', uid=[], ) diff --git a/meshroom/nodes/aliceVision/ExportDistortion.py b/meshroom/nodes/aliceVision/ExportDistortion.py index 9eee0815..a0a7373f 100644 --- a/meshroom/nodes/aliceVision/ExportDistortion.py +++ b/meshroom/nodes/aliceVision/ExportDistortion.py @@ -24,7 +24,7 @@ Export the distortion model and parameters of cameras in a SfM scene. desc.File( name='output', label='Folder', - description='', + description='Output folder.', value=desc.Node.internalFolder, uid=[], ),