3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-06-02 02:42:05 +02:00
Code Issues Projects Releases Packages Wiki Activity

[nodes] HDR Fusion: Don't send nbBrackets param for automatic detections

Browse source 
Reset the command line at every iteration to ensure that there is no
"--nbBrackets" leftovers when we are switching between the automatic
bracket detection and the manually specified brackets number.
This commit is contained in:
Candice Bentéjac 2023-07-18 17:53:06 +02:00
parent 26dee7379e
commit 6fe82a3000
3 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
meshroom/nodes/aliceVision/LdrToHdrCalibration.py
View file

@ -69,6 +69,7 @@ Calibrate LDR to HDR response curve from samples.
value=0,
range=(0, 10, 1),
uid=[0],
group="bracketsParams"
),
desc.BoolParam(
name="byPass",
@ -163,6 +164,12 @@ Calibrate LDR to HDR response curve from samples.
def processChunk(self, chunk):
if chunk.node.nbBrackets.value == 1:
return
# Trick to avoid sending --nbBrackets to the command line when the bracket detection is automatic.
# Otherwise, the AliceVision executable has no way of determining whether the bracket detection was automatic
# or if it was hard-set by the user.
self.commandLine = "aliceVision_LdrToHdrCalibration {allParams}"
if chunk.node.userNbBrackets.value == chunk.node.nbBrackets.value:
self.commandLine += "{bracketsParams}"
super(LdrToHdrCalibration, self).processChunk(chunk)
@classmethod

10
meshroom/nodes/aliceVision/LdrToHdrMerge.py
View file

@ -68,6 +68,7 @@ Merge LDR images into HDR images.
value=0,
range=(0, 10, 1),
uid=[0],
group="bracketsParams"
),
desc.BoolParam(
name="offsetRefBracketIndexEnabled",
@ -358,3 +359,12 @@ Merge LDR images into HDR images.
node.nbBrackets.value = bestBracketSize
else:
node.nbBrackets.value = 0
def processChunk(self, chunk):
# Trick to avoid sending --nbBrackets to the command line when the bracket detection is automatic.
# Otherwise, the AliceVision executable has no way of determining whether the bracket detection was automatic
# or if it was hard-set by the user.
self.commandLine = "aliceVision_LdrToHdrMerge {allParams}"
if chunk.node.userNbBrackets.value == chunk.node.nbBrackets.value:
self.commandLine += "{bracketsParams}"
super(LdrToHdrMerge, self).processChunk(chunk)

7
meshroom/nodes/aliceVision/LdrToHdrSampling.py
View file

@ -79,6 +79,7 @@ Sample pixels from Low range images for HDR creation.
value=0,
range=(0, 10, 1),
uid=[0],
group="bracketsParams"
),
desc.BoolParam(
name="byPass",
@ -184,6 +185,12 @@ Sample pixels from Low range images for HDR creation.
def processChunk(self, chunk):
if chunk.node.nbBrackets.value == 1:
return
# Trick to avoid sending --nbBrackets to the command line when the bracket detection is automatic.
# Otherwise, the AliceVision executable has no way of determining whether the bracket detection was automatic
# or if it was hard-set by the user.
self.commandLine = "aliceVision_LdrToHdrSampling {allParams}"
if chunk.node.userNbBrackets.value == chunk.node.nbBrackets.value:
self.commandLine += "{bracketsParams}"
super(LdrToHdrSampling, self).processChunk(chunk)
@classmethod