3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-04-30 10:47:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

[core] GroupAttr: no error for empty value and more explicit error message

Browse source
This commit is contained in:
Fabien Castan 2024-05-27 21:34:54 +02:00
parent 5101530b89
commit 520c25349f
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
meshroom/core/desc.py
View file

@ -144,11 +144,11 @@ class GroupAttribute(Attribute):
# invalidKeys = set(value.keys()).difference([attr.name for attr in self._groupDesc]) # invalidKeys = set(value.keys()).difference([attr.name for attr in self._groupDesc])
# if invalidKeys: # if invalidKeys:
# raise ValueError('Value contains key that does not match group description : {}'.format(invalidKeys)) # raise ValueError('Value contains key that does not match group description : {}'.format(invalidKeys))
if self._groupDesc: if self._groupDesc and value.keys():
commonKeys = set(value.keys()).intersection([attr.name for attr in self._groupDesc]) commonKeys = set(value.keys()).intersection([attr.name for attr in self._groupDesc])
if not commonKeys: if not commonKeys:
raise ValueError('Value contains no key that matches with the group description: {}'.format(commonKeys)) raise ValueError(f'Value contains no key that matches with the group description (name={self.name}, values={value.keys()}, desc={[attr.name for attr in self._groupDesc]})')
elif isinstance(value, (list, tuple)): elif isinstance(value, (list, tuple, set)):
if len(value) != len(self._groupDesc): if len(value) != len(self._groupDesc):
raise ValueError('Value contains incoherent number of values: desc size: {}, value size: {}'.format(len(self._groupDesc), len(value))) raise ValueError('Value contains incoherent number of values: desc size: {}, value size: {}'.format(len(self._groupDesc), len(value)))
else: else: